Skip to content

Commit 407f3c0

Browse files
committed
Fix mypy
1 parent 98b817a commit 407f3c0

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

jupyter_server/auth/identity.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from http.cookies import Morsel
2121

2222
from tornado import escape, httputil, web
23-
from traitlets import Bool, Dict, List, TraitError, Type, Unicode, default, validate
23+
from traitlets import Bool, Dict, Enum, List, TraitError, Type, Unicode, default, validate
2424
from traitlets.config import LoggingConfigurable
2525

2626
from jupyter_server.transutils import _i18n
@@ -194,7 +194,7 @@ class IdentityProvider(LoggingConfigurable):
194194

195195
# Define the fields that can be updated
196196
updatable_fields = List(
197-
trait=Unicode(),
197+
trait=Enum(list(t.get_args(UpdatableField))),
198198
default_value=["color"], # Default updatable field
199199
config=True,
200200
help=_i18n("List of fields in the User model that can be updated."),
@@ -296,7 +296,7 @@ def update_user(
296296
self, handler: web.RequestHandler, user_data: dict[UpdatableField, str]
297297
) -> User:
298298
"""Update user information."""
299-
current_user = handler.current_user # type:ignore[attr-defined]
299+
current_user = t.cast(User, handler.current_user)
300300

301301
for field in user_data:
302302
if field not in self.updatable_fields:

jupyter_server/services/api/handlers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
# Distributed under the terms of the Modified BSD License.
55
import json
66
import os
7-
from typing import Any
7+
from typing import Any, cast
88

99
from jupyter_core.utils import ensure_async
1010
from tornado import web
1111

1212
from jupyter_server._tz import isoformat, utcfromtimestamp
1313
from jupyter_server.auth.decorator import authorized
14-
from jupyter_server.auth.identity import IdentityProvider
14+
from jupyter_server.auth.identity import IdentityProvider, UpdatableField
1515

1616
from ...base.handlers import APIHandler, JupyterHandler
1717

@@ -118,7 +118,7 @@ async def get(self):
118118
@web.authenticated
119119
async def patch(self):
120120
"""Update user information."""
121-
user_data = self.get_json_body()
121+
user_data = cast(dict[UpdatableField, str], self.get_json_body())
122122
if not user_data:
123123
raise web.HTTPError(400, "Invalid or missing JSON body")
124124

0 commit comments

Comments
 (0)