Move the javadoc configuration to the default.

* Making the configuration of javadoc tied to the execution makes it harder for
  people to tweak the javadoc configuration as they have to invoke the lifecycle
  rather than just invoke 'mvn javadoc:javadoc' to see the effects quickly

Author: stephenc

pom.xml

@@ -230,42 +230,42 @@
                 -->
                 <artifactId>maven-javadoc-plugin</artifactId>
                 <version>2.8.1</version>
+                <configuration>
+                    <stylesheetfile>${basedir}/src/main/javadoc/stylesheet.css</stylesheetfile>
+                    <show>protected</show>
+                    <author>false</author>
+                    <version>false</version>
+                    <detectLinks>false</detectLinks>
+                    <linksource>true</linksource>
+                    <keywords>true</keywords>
+                    <use>false</use>
+                    <windowtitle>JUnit API</windowtitle>
+                    <encoding>UTF-8</encoding>
+                    <locale>en</locale>
+                    <javadocVersion>1.5</javadocVersion>
+                    <javaApiLinks>
+                        <property>
+                            <name>api_1.5</name>
+                            <value>http://docs.oracle.com/javase/1.5.0/docs/api/index.html</value>
+                        </property>
+                    </javaApiLinks>
+                    <excludePackageNames>junit.*,*.internal,*.internal.*</excludePackageNames>
+                    <verbose>true</verbose>
+                    <minmemory>32m</minmemory>
+                    <maxmemory>128m</maxmemory>
+                    <failOnError>true</failOnError>
+                    <includeDependencySources>true</includeDependencySources>
+                    <dependencySourceIncludes>
+                        <dependencySourceInclude>org.hamcrest:hamcrest-core:*</dependencySourceInclude>
+                    </dependencySourceIncludes>
+                </configuration>
                 <executions>
                     <execution>
                         <id>attach-javadoc</id>
                         <phase>package</phase>
                         <goals>
                             <goal>jar</goal>
                         </goals>
-                        <configuration>
-                            <stylesheetfile>${basedir}/src/main/javadoc/stylesheet.css</stylesheetfile>
-                            <show>protected</show>
-                            <author>false</author>
-                            <version>false</version>
-                            <detectLinks>false</detectLinks>
-                            <linksource>true</linksource>
-                            <keywords>true</keywords>
-                            <use>false</use>
-                            <windowtitle>JUnit API</windowtitle>
-                            <encoding>UTF-8</encoding>
-                            <locale>en</locale>
-                            <javadocVersion>1.5</javadocVersion>
-                            <javaApiLinks>
-                                <property>
-                                    <name>api_1.5</name>
-                                    <value>http://docs.oracle.com/javase/1.5.0/docs/api/index.html</value>
-                                </property>
-                            </javaApiLinks>
-                            <excludePackageNames>junit.*,*.internal,*.internal.*</excludePackageNames>
-                            <verbose>true</verbose>
-                            <minmemory>32m</minmemory>
-                            <maxmemory>128m</maxmemory>
-                            <failOnError>true</failOnError>
-                            <includeDependencySources>true</includeDependencySources>
-                            <dependencySourceIncludes>
-                                <dependencySourceInclude>org.hamcrest:hamcrest-core:*</dependencySourceInclude>
-                            </dependencySourceIncludes>
-                        </configuration>
                     </execution>
                 </executions>
             </plugin>