Skip to content

Commit 63acecd

Browse files
author
David Saff
committed
Merge pull request #632 from pimterry/booleanArrayEq-#86
Added boolean assertArrayEquals to Assert, fixing #86
2 parents 1b68fdb + 02371d1 commit 63acecd

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed

Diff for: src/main/java/org/junit/Assert.java

+29
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,35 @@ public static void assertArrayEquals(String message, Object[] expecteds,
295295
public static void assertArrayEquals(Object[] expecteds, Object[] actuals) {
296296
assertArrayEquals(null, expecteds, actuals);
297297
}
298+
299+
/**
300+
* Asserts that two boolean arrays are equal. If they are not, an
301+
* {@link AssertionError} is thrown with the given message. If
302+
* <code>expecteds</code> and <code>actuals</code> are <code>null</code>,
303+
* they are considered equal.
304+
*
305+
* @param message the identifying message for the {@link AssertionError} (<code>null</code>
306+
* okay)
307+
* @param expecteds boolean array with expected values.
308+
* @param actuals boolean array with expected values.
309+
*/
310+
public static void assertArrayEquals(String message, boolean[] expecteds,
311+
boolean[] actuals) throws ArrayComparisonFailure {
312+
internalArrayEquals(message, expecteds, actuals);
313+
}
314+
315+
/**
316+
* Asserts that two boolean arrays are equal. If they are not, an
317+
* {@link AssertionError} is thrown. If <code>expected</code> and
318+
* <code>actual</code> are <code>null</code>, they are considered
319+
* equal.
320+
*
321+
* @param expecteds boolean array with expected values.
322+
* @param actuals boolean array with expected values.
323+
*/
324+
public static void assertArrayEquals(boolean[] expecteds, boolean[] actuals) {
325+
assertArrayEquals(null, expecteds, actuals);
326+
}
298327

299328
/**
300329
* Asserts that two byte arrays are equal. If they are not, an

Diff for: src/test/java/org/junit/tests/assertion/AssertionTest.java

+6
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ public void multiDimensionalIntArraysAreEqual() {
151151

152152
@Test
153153
public void oneDimensionalPrimitiveArraysAreEqual() {
154+
assertArrayEquals(new boolean[]{true}, new boolean[]{true});
154155
assertArrayEquals(new byte[]{1}, new byte[]{1});
155156
assertArrayEquals(new char[]{1}, new char[]{1});
156157
assertArrayEquals(new short[]{1}, new short[]{1});
@@ -169,6 +170,11 @@ public void oneDimensionalDoubleArraysAreNotEqual() {
169170
public void oneDimensionalFloatArraysAreNotEqual() {
170171
assertArrayEquals(new float[]{1.0f}, new float[]{2.5f}, 1.0f);
171172
}
173+
174+
@Test(expected = AssertionError.class)
175+
public void oneDimensionalBooleanArraysAreNotEqual() {
176+
assertArrayEquals(new boolean[]{true}, new boolean[]{false});
177+
}
172178

173179
@Test(expected = AssertionError.class)
174180
public void IntegerDoesNotEqualLong() {

0 commit comments

Comments
 (0)