Skip to content

unittest2 is only a test requirement #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2016
Merged

unittest2 is only a test requirement #158

merged 1 commit into from
May 21, 2016

Conversation

asottile
Copy link
Contributor

No description provided.

@julien-duponchelle
Copy link
Owner

Thanks,

It seem to failed on travis for Python 2.6 and 2.5

@bjoernhaeuser
Copy link
Collaborator

Suggesting to remove python 2.6 support. Its actually not maintained anymore.

@asottile
Copy link
Contributor Author

asottile commented May 20, 2016

I guess there's three options:

  1. Change nosetests to python setup.py test (this'll honor tests_require but use setuptools installation (kinda icky))
  2. Add an extras_require for test and use pip install .[test] and use the equivalent workflow
  3. Drop python2.6 (removing unittest2 mentions entirely, and from .travis.yml)

Please advise :D

@julien-duponchelle
Copy link
Owner

If I remember some user use Python 2.6 for Red Hat 6.

But I'm not against stop testing on 2.6 and mark it as not supported.

Le ven. 20 mai 2016 à 16:49, Anthony Sottile [email protected] a
écrit :

I guess there's three options:

  1. Change nosetests to python setup.py test (this'll honor
    tests_require but use setuptools installation (kinda icky)
  2. Add an extras_require for test and use pip install .[test] and use
    the equivalent workflow
  3. Drop python2.6 (removing unittest2 mentions entirely, and from
    .travis.yml)

Please advise :D


You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#158 (comment)

@asottile
Copy link
Contributor Author

I opted for option 2, let me know what you guys think of the new diff :)

@baloo
Copy link
Collaborator

baloo commented May 20, 2016

LGTM

@bjoernhaeuser
Copy link
Collaborator

👍

@baloo baloo merged commit 2dea748 into julien-duponchelle:master May 21, 2016
@asottile asottile deleted the unittest2_test_requirement branch July 17, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants