Skip to content

Fix missing charset setting in base.py #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
starcat37 opened this issue Oct 18, 2023 · 1 comment
Closed

Fix missing charset setting in base.py #564

starcat37 opened this issue Oct 18, 2023 · 1 comment
Assignees

Comments

@starcat37
Copy link
Contributor

starcat37 commented Oct 18, 2023

Issue Description and Solution

The TestLatin1 test is currently failing and has therefore been excluded from the actual pytest run. Upon investigation, it appears that the charset setting (db["charset"] = charset) has been omitted in base.py.

def setUp(self, charset="utf8"):
# default
self.conn_control = None
db = copy.copy(self.database)
db["db"] = None
self.connect_conn_control(db)
self.execute("DROP DATABASE IF EXISTS pymysqlreplication_test")
self.execute("CREATE DATABASE pymysqlreplication_test")
db = copy.copy(self.database)
self.connect_conn_control(db)
self.stream = None
self.resetBinLog()
self.isMySQL56AndMore()
self.__is_mariaDB = None

I plan to add the missing charset setting and re-include the test_query_event_latin1 test in the pytest suite.

Special thanks to @sean-k1 for the assistance😄

@starcat37
Copy link
Contributor Author

Closed by PR #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant