You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What do you think about removing the information about self.column_schemas?
Currently we are getting the value of Column schema from information_schema and using it for Column object information (def __parse_column_definition(self, column_type, column_schema, packet)
I think the Column object should only apply values from Binlog packet values.
Currently, there is information that we get based on the values of column_schema (e.g. unsigned,zerofill, column_comment), but I think it would be better to not use these values and keep only the Column object information by extracting it from the binlog packet and optional meta data values.
Similar projects like ours, go-mysql and rust-mysql-common, do not SELECT information_schema, but only refer to column names in optional metadata.
I expect the standard will eventually be based on optional_metadata.
I'm curious about your thoughts
The text was updated successfully, but these errors were encountered:
What do you think about removing the information about self.column_schemas?
Currently we are getting the value of Column schema from information_schema and using it for Column object information (def __parse_column_definition(self, column_type, column_schema, packet)

I think the Column object should only apply values from Binlog packet values.
Currently, there is information that we get based on the values of column_schema (e.g. unsigned,zerofill, column_comment), but I think it would be better to not use these values and keep only the Column object information by extracting it from the binlog packet and optional meta data values.
Similar projects like ours, go-mysql and rust-mysql-common, do not SELECT information_schema, but only refer to column names in optional metadata.
I expect the standard will eventually be based on optional_metadata.
I'm curious about your thoughts
The text was updated successfully, but these errors were encountered: