Skip to content

Commit 93b0c3f

Browse files
author
taehun.kim
committed
Resolves in code review
1 parent 9c04832 commit 93b0c3f

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

Diff for: pymysqlreplication/tests/base.py

+4
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,10 @@ def isMySQL57(self):
7474
version = float(self.getMySQLVersion().rsplit(".", 1)[0])
7575
return version == 5.7
7676

77+
def isMySQL57AndMore(self):
78+
version = float(self.getMySQLVersion().rsplit(".", 1)[0])
79+
return version >= 5.7
80+
7781
def isMySQL80AndMore(self):
7882
version = float(self.getMySQLVersion().rsplit(".", 1)[0])
7983
return version >= 8.0

Diff for: pymysqlreplication/tests/test_basic.py

+2
Original file line numberDiff line numberDiff line change
@@ -1488,6 +1488,8 @@ def test_gtid_event(self):
14881488
server_id=1024,
14891489
only_events=[GtidEvent],
14901490
)
1491+
if not self.isMySQL57AndMore():
1492+
self.skipTest("Mysql version is under 5.7")
14911493
self.execute(
14921494
"CREATE TABLE IF NOT EXISTS test (id INT AUTO_INCREMENT PRIMARY KEY, name VARCHAR(255))"
14931495
)

0 commit comments

Comments
 (0)