Skip to content

Commit e9bb53e

Browse files
committed
fix: use routerLink instead of imperative router.navigate
see angular/angular.io#998 for reasoning
1 parent f4bb925 commit e9bb53e

File tree

5 files changed

+10
-14
lines changed

5 files changed

+10
-14
lines changed

src/client/app/+developers/+developer-details/developer-detail.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,14 @@ <h3 class="mobmid">Leaderboard </h3>
224224
FOOTER
225225
=========================== -->
226226
<footer class="text-center">
227-
<button type="submit" class="dashboard-button mdl-button mdl-js-button mdl-button--raised mdl-js-ripple-effect mdl-button--accent"
228-
(click)="onEdit(developer)">Edit Developer</button>
227+
<button class="dashboard-button mdl-button mdl-js-button mdl-button--raised mdl-js-ripple-effect mdl-button--accent"
228+
[routerLink]="['DeveloperEdit', {id: developer.id}]">Edit Developer</button>
229229
&nbsp;
230-
<button class="dashboard-button mdl-button mdl-js-button mdl-button--raised mdl-js-ripple-effect" (click)="gotoDevelopers()">Cancel</button>
230+
<button class="dashboard-button mdl-button mdl-js-button mdl-button--raised mdl-js-ripple-effect"
231+
[routerLink]="['DevelopersListing']">Cancel</button>
231232
</footer>
232233
<div>
233234
<p></p>
234235
</div>
235236

236-
</div>
237+
</div>
Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {Component, Input, ChangeDetectionStrategy} from 'angular2/core';
2-
import {Router} from 'angular2/router';
2+
import {ROUTER_DIRECTIVES} from 'angular2/router';
33

44
import {IDeveloper} from '../../developers';
55
import {ValuesPipe} from '../../values-pipe';
@@ -9,18 +9,12 @@ import {ValuesPipe} from '../../values-pipe';
99
selector: 'developer-details',
1010
templateUrl: 'app/+developers/+developer-details/developer-detail.html',
1111
inputs: ['developer'],
12+
directives: [ROUTER_DIRECTIVES],
1213
pipes: [ValuesPipe],
1314
changeDetection: ChangeDetectionStrategy.OnPush
1415
})
1516
export class DeveloperDetailComponent {
16-
constructor(private _router: Router) {}
17-
1817

1918
@Input() developer: IDeveloper;
2019

21-
onEdit(developer: IDeveloper) {
22-
this._router.navigate(['DeveloperEdit', {id: this.developer.id}]);
23-
}
24-
25-
gotoDevelopers() { this._router.navigate(['DevelopersListing']); }
2620
}

src/client/app/+developers/developers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {DeveloperService} from '../developers';
2222
loader: () => window['System'].import('app/+developers/+developer-details').then((module) => module.DeveloperDetailsComponent)
2323
},
2424
{
25-
path: '/developer-edit/',
25+
path: '/developer-edit/:id',
2626
name: 'DeveloperEdit',
2727
loader: () => window['System'].import('app/+developers/+developer-edit').then((module) => module.DeveloperEditComponent)
2828
}

src/client/app/+events/+event-edit/event-edit.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {Observable} from 'rxjs/Observable';
44

55
import {IEvent, EventsService} from '../../events';
66
import {DataService} from '../../data-service';
7+
78
import {EventEditFormComponent} from './event-editform';
89

910

src/client/app/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {EventsService} from './events';
1111
selector: 'houston-app',
1212
templateUrl: 'app/app.html',
1313
viewProviders: [],
14-
directives: [[ROUTER_DIRECTIVES]],
14+
directives: [ROUTER_DIRECTIVES],
1515
providers: [
1616
ROUTER_PROVIDERS,
1717
DataService,

0 commit comments

Comments
 (0)