[Refactor] use array.prototype.flat object.values over .reduce

Author: ljharb

package.json

@@ -63,7 +63,9 @@
   "license": "MIT",
   "dependencies": {
     "array-includes": "^3.1.6",
-    "object.assign": "^4.1.4"
+    "array.prototype.flat": "^1.3.1",
+    "object.assign": "^4.1.4",
+    "object.values": "^1.1.6"
   },
   "auto-changelog": {
     "output": "CHANGELOG.md",

src/eventHandlers.js

@@ -1,3 +1,6 @@
+import flat from 'array.prototype.flat';
+import values from 'object.values';
+
 /**
  * Common event handlers for JSX element event binding.
  */
@@ -102,11 +105,6 @@ const eventHandlersByType = {
   ],
 };
 
-const eventHandlers = Object.keys(eventHandlersByType).reduce(
-  (accumulator, type) => accumulator.concat(eventHandlersByType[type]),
-  [],
-);
-
-export default eventHandlers;
+export default flat(values(eventHandlersByType));
 
 export { eventHandlersByType };

src/values/expressions/ObjectExpression.js

@@ -10,15 +10,14 @@ export default function extractValueFromObjectExpression(value) {
   // eslint-disable-next-line global-require
   const getValue = require('.').default;
   return value.properties.reduce((obj, property) => {
-    const object = { ...obj };
     // Support types: SpreadProperty and ExperimentalSpreadProperty
     if (/^(?:Experimental)?Spread(?:Property|Element)$/.test(property.type)) {
       if (property.argument.type === 'ObjectExpression') {
-        return assign(object, extractValueFromObjectExpression(property.argument));
+        return assign({}, obj, extractValueFromObjectExpression(property.argument));
       }
     } else {
-      object[getValue(property.key)] = getValue(property.value);
+      return assign({}, obj, { [getValue(property.key)]: getValue(property.value) });
     }
-    return object;
+    return obj;
   }, {});
 }

src/values/expressions/TemplateLiteral.js

@@ -17,22 +17,19 @@ export default function extractValueFromTemplateLiteral(value) {
   } = value;
   const partitions = quasis.concat(expressions);
 
-  return partitions.sort(sortStarts).reduce((raw, part) => {
-    const {
-      type,
-    } = part;
+  return partitions.sort(sortStarts).map(({ type, value: { raw } = {}, name }) => {
     if (type === 'TemplateElement') {
-      return raw + part.value.raw;
+      return raw;
     }
 
     if (type === 'Identifier') {
-      return part.name === 'undefined' ? `${raw}${part.name}` : `${raw}{${part.name}}`;
+      return name === 'undefined' ? name : `{${name}}`;
     }
 
     if (type.indexOf('Expression') > -1) {
-      return `${raw}{${type}}`;
+      return `{${type}}`;
     }
 
-    return raw;
-  }, '');
+    return '';
+  }).join('');
 }