From 28bee4f20819fee4de2d483671e5bc20fb2f87e8 Mon Sep 17 00:00:00 2001 From: Martin Packman Date: Fri, 3 May 2019 11:29:51 +0100 Subject: [PATCH] Remove no-render-return-value from recommended This rules is about a potential future change to a ReactDOM interface not any actual problem, and is the slowest `plugin:react/recommended` by a factor of about 3. --- README.md | 1 - index.js | 1 - lib/rules/no-render-return-value.js | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/README.md b/README.md index 329e51b3a5..7552b63e30 100644 --- a/README.md +++ b/README.md @@ -219,7 +219,6 @@ The rules enabled in this configuration are: * [react/no-direct-mutation-state](docs/rules/no-direct-mutation-state.md) * [react/no-find-dom-node](docs/rules/no-find-dom-node.md) * [react/no-is-mounted](docs/rules/no-is-mounted.md) -* [react/no-render-return-value](docs/rules/no-render-return-value.md) * [react/no-string-refs](docs/rules/no-string-refs.md) * [react/no-unescaped-entities](docs/rules/no-unescaped-entities.md) * [react/no-unknown-property](docs/rules/no-unknown-property.md) diff --git a/index.js b/index.js index b2d4ccdb90..4173f00871 100644 --- a/index.js +++ b/index.js @@ -141,7 +141,6 @@ module.exports = { 'react/no-direct-mutation-state': 2, 'react/no-find-dom-node': 2, 'react/no-is-mounted': 2, - 'react/no-render-return-value': 2, 'react/no-string-refs': 2, 'react/no-unescaped-entities': 2, 'react/no-unknown-property': 2, diff --git a/lib/rules/no-render-return-value.js b/lib/rules/no-render-return-value.js index e31552de73..3018afef33 100644 --- a/lib/rules/no-render-return-value.js +++ b/lib/rules/no-render-return-value.js @@ -16,7 +16,7 @@ module.exports = { docs: { description: 'Prevent usage of the return value of React.render', category: 'Best Practices', - recommended: true, + recommended: false, url: docsUrl('no-render-return-value') }, schema: []