Skip to content

ESLint doesn't validate props if they are exported to a var or module. #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sergej-s opened this issue Apr 12, 2019 · 2 comments · Fixed by #2704
Closed

ESLint doesn't validate props if they are exported to a var or module. #2236

sergej-s opened this issue Apr 12, 2019 · 2 comments · Fixed by #2704
Labels
bug help wanted

Comments

@sergej-s
Copy link

I'm trying to apply the cenralized proptypes pattern
https://medium.freecodecamp.org/react-pattern-centralized-proptypes-f981ff672f3b
but ESLint validation doesn't work with proptypes exported or saved in a variable as shown on screenshot below

image

Could you help me to fix this?

Deps:
"eslint-plugin-react": "^7.12.4"
"eslint": "^5.16.0"
"babel-eslint": "^10.0.1"
@ljharb
Copy link
Member

ljharb commented Apr 12, 2019

cc @alexzherdev

@sergej-s
Copy link
Author

Hi! Do you have any news?

@jzabala jzabala mentioned this issue Jul 9, 2020
Merged
@ljharb ljharb closed this as completed in 5bab611 Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix]: use variable value in prop type field defined by a variable jzabala/eslint-plugin-react
2 participants
@ljharb @sergej-s