-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
jsx-pascal-case warns on valid casing when using non-English characters #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm not sure about that specific technique, but I'm very open to adding test cases that fail with the current method, and then fixing the implementation to pass those tests. |
Example of failing test case:
|
I don't know the implementation details, but this might test a case not covered by the original proposed test. { code: '<Éurströmming />' } |
Any update on this? Our component "Flervalgsspørsmål" fails this rule. |
Same here, a component called |
No update, because nobody's sent a PR. |
Added a PR (#2557) now to support Unicode characters 🙂👍 |
This rule only works when strictly using the 26 english characters hard coded in the regex.
const PASCAL_CASE_REGEX = /^([A-Z0-9]|[A-Z0-9]+[a-z0-9]+(?:[A-Z0-9]+[a-z0-9]))$/;
In order to support all cased languages, how do you feel about modifying the casing check for example using a technique similar to this (to detect letters):
The text was updated successfully, but these errors were encountered: