Skip to content

Add or modify rule for no target="_blank" to include form elements #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmarthernandez opened this issue Apr 7, 2017 · 3 comments · Fixed by #1617
Closed

Add or modify rule for no target="_blank" to include form elements #1143

jmarthernandez opened this issue Apr 7, 2017 · 3 comments · Fixed by #1617

Comments

@jmarthernandez
Copy link

      <form
        method="POST"
        action={url}
        target="_blank"
      >
          <formStuff />
      </form>

I could be wrong but isn't a form post open to the same vulnerabilities as a with target="_blank". The current implementation doesn't flag this.

@ljharb
Copy link
Member

ljharb commented Apr 7, 2017

Yes, that's a fair point.

@jmarthernandez
Copy link
Author

Would it make sense to add to the current rule or add a new one? I could help out with that

@ljharb
Copy link
Member

ljharb commented Apr 7, 2017

I think an option added to the current rule would be great; we could default it to false for now and true in a later semver-major PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants