Skip to content

Commit e1a6f56

Browse files
authored
fixup: Apply suggestions from code review
1 parent 36e2f39 commit e1a6f56

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

lib/rules/jsx-sort-props.js

+6-8
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,10 @@ function getGroupsOfSortableAttributes(attributes, context) {
151151
const attribute = attributes[i];
152152
const nextAttribute = attributes[i + 1];
153153
const attributeline = attribute.loc.start.line;
154-
let comment = []
154+
let comment = [];
155155
try {
156-
comment = sourceCode.getCommentsAfter(attribute)
157-
} catch (e) {
158-
} finally {
159-
}
156+
comment = sourceCode.getCommentsAfter(attribute);
157+
} catch (e) { /**/ }
160158
const lastAttr = attributes[i - 1];
161159
const attrIsSpread = attribute.type === 'JSXSpreadAttribute';
162160

@@ -181,11 +179,11 @@ function getGroupsOfSortableAttributes(attributes, context) {
181179
if (attributeline + 1 === commentline && nextAttribute) {
182180
attributeMap.set(attribute, [nextAttribute.range[1], true]);
183181
addtoSortableAttributeGroups(attribute);
184-
i++;
182+
i += 1;
185183
} else if (attributeline === commentline) {
186184
if (firstComment.type === 'Block') {
187185
attributeMap.set(attribute, [nextAttribute.range[1], true]);
188-
i++;
186+
i += 1;
189187
} else {
190188
attributeMap.set(attribute, [firstComment.range[1], false]);
191189
}
@@ -201,7 +199,7 @@ function getGroupsOfSortableAttributes(attributes, context) {
201199
attributeMap.set(attribute, [commentNextAttribute[0].range[1], true]);
202200
}
203201
addtoSortableAttributeGroups(attribute);
204-
i++;
202+
i += 1;
205203
}
206204
}
207205
}

0 commit comments

Comments
 (0)