Skip to content

Commit da2c7d2

Browse files
jichu4nljharb
authored andcommitted
[Fix] no-render-return-value: should warn when used in assignment expression
Fixes #2461.
1 parent 360d74a commit da2c7d2

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

lib/rules/no-render-return-value.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ module.exports = {
5858
parent.type === 'VariableDeclarator' ||
5959
parent.type === 'Property' ||
6060
parent.type === 'ReturnStatement' ||
61-
parent.type === 'ArrowFunctionExpression'
61+
parent.type === 'ArrowFunctionExpression' ||
62+
parent.type === 'AssignmentExpression'
6263
) {
6364
context.report({
6465
node: callee,

tests/lib/rules/no-render-return-value.js

+10
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,16 @@ ruleTester.run('no-render-return-value', rule, {
9696
errors: [{
9797
message: 'Do not depend on the return value from ReactDOM.render'
9898
}]
99+
}, {
100+
code: 'this.o = ReactDOM.render(<div />, document.body);',
101+
errors: [{
102+
message: 'Do not depend on the return value from ReactDOM.render'
103+
}]
104+
}, {
105+
code: 'var v; v = ReactDOM.render(<div />, document.body);',
106+
errors: [{
107+
message: 'Do not depend on the return value from ReactDOM.render'
108+
}]
99109
}, {
100110
code: 'var inst = React.render(<div />, document.body);',
101111
settings: {

0 commit comments

Comments
 (0)