Skip to content

Commit d060041

Browse files
authored
Merge pull request #1659 from jzDev/jzDev/flip-crossorigin-rule
Fixed crossorigin naming convention and missing tag support.
2 parents 843d71a + 1d13218 commit d060041

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lib/rules/no-unknown-property.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ const DOM_ATTRIBUTE_NAMES = {
2222
class: 'className',
2323
for: 'htmlFor',
2424
'http-equiv': 'httpEquiv',
25-
crossOrigin: 'crossorigin'
25+
crossorigin: 'crossOrigin'
2626
};
2727

2828
const ATTRIBUTE_TAGS_MAP = {
29-
crossorigin: ['script', 'img', 'video']
29+
crossOrigin: ['script', 'img', 'video', 'link']
3030
};
3131

3232
const SVGDOM_ATTRIBUTE_NAMES = {

tests/lib/rules/no-unknown-property.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ ruleTester.run('no-unknown-property', rule, {
4242
code: '<div class="bar"></div>;',
4343
options: [{ignore: ['class']}]
4444
},
45-
{code: '<script crossorigin />'}
45+
{code: '<script crossOrigin />'}
4646
],
4747
invalid: [{
4848
code: '<div class="bar"></div>;',
@@ -81,13 +81,13 @@ ruleTester.run('no-unknown-property', rule, {
8181
output: '<rect clipPath="bar" />;',
8282
errors: [{message: 'Unknown property \'clip-path\' found, use \'clipPath\' instead'}]
8383
}, {
84-
code: '<script crossOrigin />',
85-
errors: [{message: 'Unknown property \'crossOrigin\' found, use \'crossorigin\' instead'}]
86-
}, {
87-
code: '<div crossOrigin />',
88-
errors: [{message: 'Unknown property \'crossOrigin\' found, use \'crossorigin\' instead'}]
84+
code: '<script crossorigin />',
85+
errors: [{message: 'Unknown property \'crossorigin\' found, use \'crossOrigin\' instead'}]
8986
}, {
9087
code: '<div crossorigin />',
91-
errors: [{message: 'Invalid property \'crossorigin\' found on tag \'div\', but it is only allowed on: script, img, video'}]
88+
errors: [{message: 'Unknown property \'crossorigin\' found, use \'crossOrigin\' instead'}]
89+
}, {
90+
code: '<div crossOrigin />',
91+
errors: [{message: 'Invalid property \'crossOrigin\' found on tag \'div\', but it is only allowed on: script, img, video, link'}]
9292
}]
9393
});

0 commit comments

Comments
 (0)