use better practices

thanks @lencioni

Author: TSMMark

lib/rules/jsx-one-expression-per-line.js

@@ -52,7 +52,7 @@ module.exports = {
           let countNewLinesAfterContent = 0;
 
           if (child.type === 'Literal') {
-            if (child.value.match(/^\s*$/)) {
+            if (/^\s*$/.test(child.raw)) {
               return;
             }
 
@@ -80,8 +80,8 @@ module.exports = {
           }
         });
 
-        Object.keys(childrenGroupedByLine).forEach(line => {
-          line = parseInt(line, 10);
+        Object.keys(childrenGroupedByLine).forEach(_line => {
+          const line = parseInt(_line, 10);
           const firstIndex = 0;
           const lastIndex = childrenGroupedByLine[line].length - 1;
 
@@ -107,14 +107,14 @@ module.exports = {
             }
 
             function spaceBetweenPrev () {
-              return (prevChild.type === 'Literal' && prevChild.raw.match(/ $/)) ||
-                (child.type === 'Literal' && child.raw.match(/^ /)) ||
+              return (prevChild.type === 'Literal' && / $/.test(prevChild.raw)) ||
+                (child.type === 'Literal' && /^ /.test(child.raw)) ||
                 sourceCode.isSpaceBetweenTokens(prevChild, child);
             }
 
             function spaceBetweenNext () {
-              return (nextChild.type === 'Literal' && nextChild.raw.match(/^ /)) ||
-                (child.type === 'Literal' && child.raw.match(/ $/)) ||
+              return (nextChild.type === 'Literal' && /^ /.test(nextChild.raw)) ||
+                (child.type === 'Literal' && / $/.test(child.raw)) ||
                 sourceCode.isSpaceBetweenTokens(child, nextChild);
             }
 
@@ -125,8 +125,8 @@ module.exports = {
             const source = sourceCode.getText(child);
             const leadingSpace = !!(prevChild && spaceBetweenPrev());
             const trailingSpace = !!(nextChild && spaceBetweenNext());
-            const leadingNewLine = !!(prevChild);
-            const trailingNewLine = !!(nextChild);
+            const leadingNewLine = !!prevChild;
+            const trailingNewLine = !!nextChild;
 
             const key = nodeKey(child);