Skip to content

Commit 72a71b3

Browse files
committed
[Fix] jsx-no-target-blank: don’t crash when there’s no value
Fixes #1949.
1 parent 6b239a7 commit 72a71b3

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lib/rules/jsx-no-target-blank.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ const docsUrl = require('../util/docsUrl');
1111
// ------------------------------------------------------------------------------
1212

1313
function isTargetBlank(attr) {
14-
return attr.name.name === 'target' &&
14+
return attr.name &&
15+
attr.name.name === 'target' &&
16+
attr.value &&
1517
attr.value.type === 'Literal' &&
1618
attr.value.value.toLowerCase() === '_blank';
1719
}

tests/lib/rules/jsx-no-target-blank.js

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ ruleTester.run('jsx-no-target-blank', rule, {
3333
valid: [
3434
{code: '<a href="foobar"></a>'},
3535
{code: '<a randomTag></a>'},
36+
{code: '<a target />'},
3637
{code: '<a href="foobar" target="_blank" rel="noopener noreferrer"></a>'},
3738
{code: '<a target="_blank" {...spreadProps} rel="noopener noreferrer"></a>'},
3839
{code: '<a {...spreadProps} target="_blank" rel="noopener noreferrer" href="http://example.com">s</a>'},

0 commit comments

Comments
 (0)