[Refactor] avoid for..in loops

Author: ljharb

index.js

@@ -1,6 +1,7 @@
 'use strict';
 
-const has = require('has');
+const fromEntries = require('object.fromentries');
+const entries = require('object.entries');
 
 const allRules = {
   'boolean-prop-naming': require('./lib/rules/boolean-prop-naming'),
@@ -88,24 +89,11 @@ const allRules = {
 };
 
 function filterRules(rules, predicate) {
-  const result = {};
-  for (const key in rules) {
-    if (has(rules, key) && predicate(rules[key])) {
-      result[key] = rules[key];
-    }
-  }
-  return result;
+  return fromEntries(entries(rules).filter(entry => predicate(entry[1])));
 }
 
 function configureAsError(rules) {
-  const result = {};
-  for (const key in rules) {
-    if (!has(rules, key)) {
-      continue;
-    }
-    result[`react/${key}`] = 2;
-  }
-  return result;
+  return fromEntries(Object.keys(rules).map(key => [`react/${key}`, 2]));
 }
 
 const activeRules = filterRules(allRules, rule => !rule.meta.deprecated);

lib/rules/no-deprecated.js

@@ -7,7 +7,7 @@
 
 'use strict';
 
-const has = require('has');
+const values = require('object.values');
 
 const Components = require('../util/Components');
 const astUtil = require('../util/ast');
@@ -137,15 +137,12 @@ module.exports = {
       if (!node.init) {
         return moduleName;
       }
-      for (const module in MODULES) {
-        if (!has(MODULES, module)) {
-          continue;
-        }
-        moduleName = MODULES[module].find(name => name === node.init.name);
-        if (moduleName) {
-          break;
-        }
-      }
+
+      values(MODULES).some((moduleNames) => {
+        moduleName = moduleNames.find(name => name === node.init.name);
+        return moduleName;
+      });
+
       return moduleName;
     }
 

package.json

@@ -30,7 +30,9 @@
     "doctrine": "^2.1.0",
     "has": "^1.0.3",
     "jsx-ast-utils": "^2.1.0",
+    "object.entries": "^1.1.0",
     "object.fromentries": "^2.0.0",
+    "object.values": "^1.1.0",
     "prop-types": "^15.7.2",
     "resolve": "^1.10.1"
   },