Skip to content

Commit 66b9d0c

Browse files
authored
Merge branch 'jsx-eslint:master' into akul/no-leaked-render-boolean-report
2 parents e18e8af + 03cd4b5 commit 66b9d0c

File tree

120 files changed

+2262
-333
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

120 files changed

+2262
-333
lines changed

.github/workflows/node-18+.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'Tests: node.js'
1+
name: 'Tests: node.js (18+)'
22

33
on: [pull_request, push]
44

@@ -39,7 +39,7 @@ jobs:
3939
- 8
4040

4141
steps:
42-
- uses: actions/checkout@v3
42+
- uses: actions/checkout@v4
4343
- uses: ljharb/actions/node/install@main
4444
name: 'nvm install ${{ matrix.node-version }} && npm install'
4545
with:
@@ -50,7 +50,7 @@ jobs:
5050
NPM_CONFIG_LEGACY_PEER_DEPS: true
5151
- run: npx ls-engines
5252
- run: npm run unit-test
53-
- uses: codecov/codecov-action@v3
53+
- uses: codecov/codecov-action@v3.1.5
5454

5555
node:
5656
name: 'node 18+'

.github/workflows/node-minors.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'Tests: node.js'
1+
name: 'Tests: node.js (4 - 18)'
22

33
on: [pull_request, push]
44

@@ -94,7 +94,7 @@ jobs:
9494
eslint: 5
9595

9696
steps:
97-
- uses: actions/checkout@v3
97+
- uses: actions/checkout@v4
9898
- uses: ljharb/actions/node/install@main
9999
name: 'nvm install ${{ matrix.node-version }} && npm install'
100100
with:
@@ -107,7 +107,7 @@ jobs:
107107
- run: npx ls-engines
108108
if: ${{ matrix.node-version >= 12 }}
109109
- run: npm run unit-test
110-
- uses: codecov/codecov-action@v3
110+
- uses: codecov/codecov-action@v3.1.5
111111

112112
node:
113113
name: 'node 4 - 17'

.github/workflows/node-pretest.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ubuntu-latest
88

99
steps:
10-
- uses: actions/checkout@v3
10+
- uses: actions/checkout@v4
1111
- uses: ljharb/actions/node/install@main
1212
name: 'nvm install lts/* && npm install'
1313
with:
@@ -20,7 +20,7 @@ jobs:
2020
runs-on: ubuntu-latest
2121

2222
steps:
23-
- uses: actions/checkout@v3
23+
- uses: actions/checkout@v4
2424
- uses: ljharb/actions/node/install@main
2525
name: 'nvm install lts/* && npm install'
2626
with:

.github/workflows/npm-publish.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
outputs:
1616
is-new-version: ${{ steps.cpv.outputs.is-new-version }}
1717
steps:
18-
- uses: actions/checkout@v3
18+
- uses: actions/checkout@v4
1919
with:
2020
ref: ${{ github.event.inputs.tag }}
2121

@@ -103,7 +103,7 @@ jobs:
103103
prod.api.stepsecurity.io:443
104104
registry.npmjs.org:443
105105
106-
- uses: actions/checkout@v3
106+
- uses: actions/checkout@v4
107107
with:
108108
ref: ${{ github.event.inputs.tag }}
109109

.github/workflows/rebase.yml

+3-9
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ on: [pull_request_target]
44

55
jobs:
66
_:
7-
name: "Automatic Rebase"
8-
9-
runs-on: ubuntu-latest
10-
11-
steps:
12-
- uses: actions/checkout@v3
13-
- uses: ljharb/rebase@master
14-
env:
15-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7+
uses: ljharb/actions/.github/workflows/rebase.yml@main
8+
secrets:
9+
token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
run: echo "current_version=${GITHUB_REF#refs/tags/v}" >> "$GITHUB_OUTPUT"
2727
shell: bash
2828

29-
- uses: actions/checkout@v3
29+
- uses: actions/checkout@v4
3030

3131
- uses: mindsers/changelog-reader-action@v2
3232
id: changelog_reader

.github/workflows/smoke-test.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
if: ${{ github.repository == 'jsx-eslint/eslint-plugin-react' || github.event_name == 'workflow_dispatch' }}
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v3
13+
- uses: actions/checkout@v4
1414
- uses: ljharb/actions/node/install@main
1515
name: 'nvm install lts/* && npm install'
1616
with:
@@ -19,7 +19,8 @@ jobs:
1919
- run: |
2020
npm link
2121
npm link eslint-plugin-react
22-
- uses: AriPerkkio/eslint-remote-tester-run-action@v3
22+
- uses: AriPerkkio/eslint-remote-tester-run-action@v4
2323
with:
2424
issue-title: 'Results of weekly scheduled smoke test'
25+
issue-label: 'smoke-test'
2526
eslint-remote-tester-config: test/eslint-remote-tester.config.js

CHANGELOG.md

+84
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,97 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
55

66
## Unreleased
77

8+
### Fixed
9+
* [`boolean-prop-naming`]: avoid a crash with a non-TSTypeReference type ([#3718][] @developer-bandi)
10+
11+
[#3718]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3718
12+
13+
## [7.34.1] - 2024.03.15
14+
15+
### Fixed
16+
* [`jsx-no-leaked-render`]: prevent wrongly adding parens ([#3700][] @developer-bandi)
17+
* [`boolean-prop-naming`]: detect TS interfaces ([#3701][] @developer-bandi)
18+
* [`boolean-prop-naming`]: literalType error fix ([#3704][] @developer-bandi)
19+
* [`boolean-prop-naming`]: allow TSIntersectionType ([#3705][] @developer-bandi)
20+
* [`no-unknown-property`]: support `popover`, `popovertarget`, `popovertargetaction` attributes ([#3707][] @ljharb)
21+
* [`no-unknown-property`]: only match `data-*` attributes containing `-` ([#3713][] @silverwind)
22+
* [`checked-requires-onchange-or-readonly`]: correct options that were behaving opposite ([#3715][] @jaesoekjjang)
23+
24+
### Changed
25+
* [`boolean-prop-naming`]: improve error message (@ljharb)
26+
27+
[7.34.1]: https://github.com/jsx-eslint/eslint-plugin-react/compare/v7.34.0...v7.34.1
28+
[#3715]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3715
29+
[#3713]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3713
30+
[#3707]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3707
31+
[#3705]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3705
32+
[#3704]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3704
33+
[#3701]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3701
34+
[#3700]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3700
35+
36+
## [7.34.0] - 2024.03.03
37+
838
### Added
939
* [`sort-prop-types`]: give errors on TS types ([#3615][] @akulsr0)
40+
* [`no-invalid-html-attribute`]: add support for `apple-touch-startup-image` `rel` attributes in `link` tags ([#3638][] @thomashockaday)
41+
* [`no-unknown-property`]: add requireDataLowercase option ([#3645][] @HermanBilous)
42+
* [`no-unknown-property`]: add `displaystyle` on `<math>` ([#3652][] @lounsbrough)
43+
* [`prefer-read-only-props`], [`prop-types`], component detection: allow components to be async functions ([#3654][] @pnodet)
44+
* [`no-unknown-property`]: support `onResize` on audio/video tags ([#3662][] @caesar1030)
45+
* [`jsx-wrap-multilines`]: add `never` option to prohibit wrapping parens on multiline JSX ([#3668][] @reedws)
46+
* [`jsx-filename-extension`]: add `ignoreFilesWithoutCode` option to allow empty files ([#3674][] @burtek)
47+
* [`jsx-boolean-value`]: add `assumeUndefinedIsFalse` option ([#3675][] @developer-bandi)
48+
* `linkAttribute` setting, [`jsx-no-target-blank`]: support multiple properties ([#3673][] @burtek)
49+
* [`jsx-no-script-url`]: add `includeFromSettings` option to support `linkAttributes` setting ([#3673][] @burtek)
50+
* [`jsx-one-expression-per-line`]: add `non-jsx` option to allow non-JSX children in one line ([#3677][] @burtek)
51+
* add [`checked-requires-onchange-or-readonly`] rule ([#3680][] @jaesoekjjang)
1052

1153
### Fixed
1254
* [`jsx-no-leaked-render`]: preserve RHS parens for multiline jsx elements while fixing ([#3623][] @akulsr0)
55+
* [`jsx-key`]: detect conditional returns ([#3630][] @yialo)
56+
* [`jsx-newline`]: prevent a crash when `allowMultilines` ([#3633][] @ljharb)
57+
* [`no-unknown-property`]: use a better regex to avoid a crash ([#3666][] @ljharb @SCH227)
58+
* [`prop-types`]: handle nested forwardRef + memo ([#3679][] @developer-bandi)
59+
* [`no-unknown-property`]: add `fetchPriority` ([#3697][] @SevereCloud)
60+
* [`forbid-elements`]: prevent a crash on `createElement()` ([#3632][] @ljharb)
1361

62+
### Changed
63+
* [`jsx-boolean-value`]: make error messages clearer ([#3691][] @developer-bandi)
64+
* [Refactor] `propTypes`: extract type params to var ([#3634][] @HenryBrown0)
65+
* [Refactor] [`boolean-prop-naming`]: invert if statement ([#3634][] @HenryBrown0)
66+
* [Refactor] [`function-component-definition`]: exit early if no type params ([#3634][] @HenryBrown0)
67+
* [Refactor] [`jsx-props-no-multi-spaces`]: extract type parameters to var ([#3634][] @HenryBrown0)
68+
* [Docs] [`jsx-key`]: fix correct example ([#3656][] @developer-bandi)
69+
* [Tests] `jsx-wrap-multilines`: passing tests ([#3545][] @burtek)
70+
* [Docs] [`iframe-missing-sandbox`]: fix link to iframe attribute on mdn ([#3690][] @nnmrts)
71+
* [Docs] [`hook-use-state`]: fix an undefined variable ([#3626][] @chentsulin)
72+
73+
[7.34.0]: https://github.com/jsx-eslint/eslint-plugin-react/compare/v7.33.2...v7.34.0
74+
[#3697]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3697
75+
[#3691]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3691
76+
[#3690]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3690
77+
[#3680]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3680
78+
[#3679]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3679
79+
[#3677]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3677
80+
[#3675]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3675
81+
[#3674]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3674
82+
[#3673]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3673
83+
[#3668]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3668
84+
[#3666]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3666
85+
[#3662]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3662
86+
[#3656]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3656
87+
[#3654]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3654
88+
[#3652]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3652
89+
[#3645]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3645
90+
[#3638]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3638
91+
[#3634]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3634
92+
[#3633]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3633
93+
[#3632]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3632
94+
[#3630]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3630
95+
[#3626]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3626
1496
[#3623]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3623
1597
[#3615]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3615
98+
[#3545]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3545
1699

17100
## [7.33.2] - 2023.08.15
18101

@@ -4098,6 +4181,7 @@ If you're still not using React 15 you can keep the old behavior by setting the
40984181

40994182
[`boolean-prop-naming`]: docs/rules/boolean-prop-naming.md
41004183
[`button-has-type`]: docs/rules/button-has-type.md
4184+
[`checked-requires-onchange-or-readonly`]: docs/rules/checked-requires-onchange-or-readonly.md
41014185
[`default-props-match-prop-types`]: docs/rules/default-props-match-prop-types.md
41024186
[`destructuring-assignment`]: docs/rules/destructuring-assignment.md
41034187
[`display-name`]: docs/rules/display-name.md

0 commit comments

Comments
 (0)