[eslint] change severity to error and manually fix global-require

Author: golopot

.eslintrc

@@ -30,7 +30,6 @@
         "no-plusplus": 1,
         "no-param-reassign": 1,
         "no-mixed-operators": 1,
-        "global-require": 1,
         "no-restricted-syntax": 1,
         "valid-jsdoc": 1,
     },

index.js

@@ -3,6 +3,7 @@
 const fromEntries = require('object.fromentries');
 const entries = require('object.entries');
 
+/* eslint-disable global-require */
 const allRules = {
   'boolean-prop-naming': require('./lib/rules/boolean-prop-naming'),
   'button-has-type': require('./lib/rules/button-has-type'),
@@ -88,6 +89,7 @@ const allRules = {
   'style-prop-object': require('./lib/rules/style-prop-object'),
   'void-dom-elements-no-children': require('./lib/rules/void-dom-elements-no-children')
 };
+/* eslint-enable */
 
 function filterRules(rules, predicate) {
   return fromEntries(entries(rules).filter(entry => predicate(entry[1])));

lib/util/version.js

@@ -17,7 +17,7 @@ function resetWarningFlag() {
 function detectReactVersion() {
   try {
     const reactPath = resolve.sync('react', {basedir: process.cwd()});
-    const react = require(reactPath); // eslint-disable-line import/no-dynamic-require
+    const react = require(reactPath); // eslint-disable-line global-require, import/no-dynamic-require
     return react.version;
   } catch (e) {
     if (e.code === 'MODULE_NOT_FOUND') {
@@ -57,7 +57,7 @@ function getReactVersionFromContext(context) {
 function detectFlowVersion() {
   try {
     const flowPackageJsonPath = resolve.sync('flow-bin/package.json', {basedir: process.cwd()});
-    const flowPackageJson = require(flowPackageJsonPath); // eslint-disable-line import/no-dynamic-require
+    const flowPackageJson = require(flowPackageJsonPath); // eslint-disable-line global-require, import/no-dynamic-require
     return flowPackageJson.version;
   } catch (e) {
     if (e.code === 'MODULE_NOT_FOUND') {

tests/index.js

@@ -16,7 +16,7 @@ describe('all rule files should be exported by the plugin', () => {
     it(`should export ${ruleName}`, () => {
       assert.equal(
         plugin.rules[ruleName],
-        require(path.join('../lib/rules', ruleName)) // eslint-disable-line import/no-dynamic-require
+        require(path.join('../lib/rules', ruleName)) // eslint-disable-line global-require, import/no-dynamic-require
       );
     });
   });