Don't add new line after block commments

Author: justmejulian

lib/rules/jsx-newline.js

@@ -72,6 +72,11 @@ module.exports = {
     const jsxElementParents = new Set();
     const sourceCode = context.getSourceCode();
 
+    function isBlockCommentInCurlyBraces(element) {
+      const elementRawValue = sourceCode.getText(element);
+      return /^\s*{\/\*/.test(elementRawValue);
+    }
+
     return {
       'Program:exit'() {
         jsxElementParents.forEach((parent) => {
@@ -115,6 +120,9 @@ module.exports = {
               }
 
               if (isWithoutNewLine === prevent) return;
+
+              if (isBlockCommentInCurlyBraces(element)) return;
+
               const messageId = prevent
                 ? 'prevent'
                 : 'require';

tests/lib/rules/jsx-newline.js

@@ -105,6 +105,43 @@ new RuleTester({ parserOptions }).run('jsx-newline', rule, {
         </Button>
       `,
     },
+    {
+      code: `
+        <Button popoverOpen='#settings-popover' style={{ width: 'fit-content' }}>
+          {/* fake-eslint-disable-next-line should also work insinde a component */}
+          <Icon f7='gear' />
+        </Button>
+      `,
+    },
+    {
+      code: `
+        <Button popoverOpen='#settings-popover' style={{ width: 'fit-content' }}>
+          {/* should work insinde a component */}
+          {/* and it should work when using multiple comments */}
+          <Icon f7='gear' />
+        </Button>
+      `,
+    },
+    {
+      code: `
+        <Button popoverOpen='#settings-popover' style={{ width: 'fit-content' }}>
+          {/* this is a multiline
+              block comment */}
+          <Icon f7='gear' />
+        </Button>
+      `,
+    },
+    {
+      code: `
+        <>
+          {/* does this */}
+          <Icon f7='gear' />
+
+          {/* also work with multiple components and inside a fragment? */}
+          <OneLineComponent />
+        </>
+      `,
+    },
     {
       code: `
         <>
@@ -223,6 +260,30 @@ new RuleTester({ parserOptions }).run('jsx-newline', rule, {
       `,
       errors: [{ messageId: 'require' }],
     },
+    {
+      code: `
+        <div>
+          {/* This should however still not work*/}
+          <Icon f7='gear' />
+
+          <OneLineComponent />
+          {/* Comments between components still need a newLine */}
+          <OneLineComponent />
+        </div>
+      `,
+      output: `
+        <div>
+          {/* This should however still not work*/}
+          <Icon f7='gear' />
+
+          <OneLineComponent />
+
+          {/* Comments between components still need a newLine */}
+          <OneLineComponent />
+        </div>
+      `,
+      errors: [{ messageId: 'require' }],
+    },
     {
       code: `
         <div>