no-context: boost test coverage, remove ClassProperty

Author: zachguo

lib/rules/no-context.js

@@ -40,18 +40,6 @@ module.exports = {
    * @returns {Boolean} True if we are declaring a context, false if not.
    */
     function isContextTypesDeclaration(node) {
-      // Special case for class properties
-      // (babel-eslint does not expose property name so we have to rely on tokens)
-      if (node && node.type === 'ClassProperty') {
-        var tokens = context.getFirstTokens(node, 2);
-        if (
-          tokens[0].value === 'contextTypes' ||
-          (tokens[1] && tokens[1].value === 'contextTypes')
-        ) {
-          return true;
-        }
-        return false;
-      }
       return Boolean(
         node &&
         node.name === 'contextTypes'
@@ -87,15 +75,6 @@ module.exports = {
 
     return {
 
-      ClassProperty: function(node) {
-        if (isContextTypesDeclaration(node)) {
-          context.report({
-            node: node,
-            message: 'Using context is not allowed.'
-          });
-        }
-      },
-
       MemberExpression: function(node) {
         if (
           isContextUsage(node) ||

tests/lib/rules/no-context.js

@@ -42,6 +42,23 @@ ruleTester.run('no-context', rule, {
       '};'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    code: [
+      'var Hello = React.createClass({',
+      '  render: function() {',
+      '    return <div>Hello {this.props.name}</div>;',
+      '  }',
+      '});'
+    ].join('\n'),
+    parser: 'babel-eslint'
+  }, {
+    code: [
+      'var Hello = function() {',
+      '  var context;',
+      '  return context;',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }],
 
   invalid: [{
@@ -96,6 +113,19 @@ ruleTester.run('no-context', rule, {
     errors: [{
       message: 'Using context is not allowed.'
     }]
+  }, {
+    code: [
+      'class Hello extends React.Component {',
+      '  render() {',
+      '    const {name} = this.context;',
+      '    return <div>Hello {name}</div>;',
+      '  }',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    errors: [{
+      message: 'Using context is not allowed.'
+    }]
   }, {
     code: [
       'const Hello = (props, context) => {',