rename "cast" option to "coerce"

Author: Belco90

docs/rules/jsx-no-leaked-render.md

@@ -142,13 +142,13 @@ const Component = ({ elements }) => {
 The supported options are:
 
 ### `validStrategies`
-An array containing `"cast"`, `"ternary"` or both (default: `["ternary", "cast"]`) - Decide which strategies are considered valid to prevent leaked renders (at least 1 is required). The "cast" option will cast to boolean the condition of the JSX expression. The "ternary" option transforms the binary expression into a ternary expression returning `null` for falsy values. The first option from the array will be used as autofix, so the order of the values matter.
+An array containing `"coerce"`, `"ternary"`, or both (default: `["ternary", "coerce"]`) - Decide which strategies are considered valid to prevent leaked renders (at least 1 is required). The "coerce" option will cast to boolean the condition of the JSX expression. The "ternary" option transforms the binary expression into a ternary expression returning `null` for falsy values. The first option from the array will be used as autofix, so the order of the values matter.
 
 It can be set like:
 ```json5
 {
   // ...
-  "react/jsx-no-leaked-render": [<enabled>, { "validStrategies": ["ternary", "cast"] }]
+  "react/jsx-no-leaked-render": [<enabled>, { "validStrategies": ["ternary", "coerce"] }]
   // ...
 }
 ```
@@ -175,7 +175,7 @@ const Component = ({ count, title }) => {
 }
 ```
 
-Assuming the following options: `{ "validStrategies": ["cast"] }`
+Assuming the following options: `{ "validStrategies": ["coerce"] }`
 
 Examples of **incorrect** code for this rule, with the above configuration:
 ```jsx

lib/rules/jsx-no-leaked-render.js

@@ -17,9 +17,9 @@ const messages = {
   noPotentialLeakedRender: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
 };
 
-const CAST_STRATEGY = 'cast';
+const COERCE_STRATEGY = 'coerce';
 const TERNARY_STRATEGY = 'ternary';
-const DEFAULT_VALID_STRATEGIES = [TERNARY_STRATEGY, CAST_STRATEGY];
+const DEFAULT_VALID_STRATEGIES = [TERNARY_STRATEGY, COERCE_STRATEGY];
 
 /**
  * @type {import('eslint').Rule.RuleModule}
@@ -45,7 +45,7 @@ module.exports = {
             items: {
               enum: [
                 TERNARY_STRATEGY,
-                CAST_STRATEGY,
+                COERCE_STRATEGY,
               ],
             },
             uniqueItems: true,
@@ -76,7 +76,7 @@ module.exports = {
       const sourceCode = context.getSourceCode();
       const rightSideText = sourceCode.getText(rightNode);
 
-      if (fixStrategy === CAST_STRATEGY) {
+      if (fixStrategy === COERCE_STRATEGY) {
         let leftSideText = sourceCode.getText(leftNode);
         if (isParenthesized(context, leftNode)) {
           leftSideText = `(${leftSideText})`;
@@ -102,7 +102,7 @@ module.exports = {
       'JSXExpressionContainer > LogicalExpression[operator="&&"]'(node) {
         const leftSide = node.left;
         const CAST_VALID_LEFT_SIDE_EXPRESSIONS = ['UnaryExpression', 'BinaryExpression', 'CallExpression'];
-        const isCastStrategyValid = areBothStrategiesValid || fixStrategy === CAST_STRATEGY;
+        const isCastStrategyValid = areBothStrategiesValid || fixStrategy === COERCE_STRATEGY;
         const isCastValidLeftExpression = CAST_VALID_LEFT_SIDE_EXPRESSIONS.some(
           (validExpression) => validExpression === leftSide.type
         );

tests/lib/rules/jsx-no-leaked-render.js

@@ -101,23 +101,23 @@ ruleTester.run('jsx-no-leaked-render', rule, {
       `,
     },
     {
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       code: `
         const Component = ({ elements, count }) => {
           return <div>{!!count && <List elements={elements}/>}</div>
         }
       `,
     },
     {
-      options: [{ validStrategies: ['cast', 'ternary'] }],
+      options: [{ validStrategies: ['coerce', 'ternary'] }],
       code: `
         const Component = ({ elements, count }) => {
           return <div>{count ? <List elements={elements}/> : null}</div>
         }
       `,
     },
     {
-      options: [{ validStrategies: ['cast', 'ternary'] }],
+      options: [{ validStrategies: ['coerce', 'ternary'] }],
       code: `
         const Component = ({ elements, count }) => {
           return <div>{!!count && <List elements={elements}/>}</div>
@@ -132,11 +132,11 @@ ruleTester.run('jsx-no-leaked-render', rule, {
       code: `
       const Example = () => {
         return (
-          <>
+          <div>
             {0 && <Something/>}
             {'' && <Something/>}
             {NaN && <Something/>}
-          </>
+          </div>
         )
       }
       `,
@@ -279,7 +279,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
         }
       `,
-      options: [{ validStrategies: ['cast', 'ternary'] }],
+      options: [{ validStrategies: ['coerce', 'ternary'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -402,7 +402,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
       `,
     },
 
-    // cases: boolean cast isn't valid if strategy is only "ternary"
+    // cases: boolean coerce isn't valid if strategy is only "ternary"
     {
       code: `
         const Component = ({ someCondition, title }) => {
@@ -512,14 +512,14 @@ ruleTester.run('jsx-no-leaked-render', rule, {
       `,
     },
 
-    // Invalid tests only with "cast" strategy enabled
+    // Invalid tests only with "coerce" strategy enabled
     {
       code: `
         const Component = ({ count, title }) => {
           return <div>{count && title}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -537,7 +537,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{count && <span>There are {count} results</span>}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -555,7 +555,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{elements.length && <List elements={elements}/>}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -573,7 +573,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{nestedCollection.elements.length && <List elements={nestedCollection.elements}/>}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -591,7 +591,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{elements[0] && <List elements={elements}/>}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -609,7 +609,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -622,14 +622,14 @@ ruleTester.run('jsx-no-leaked-render', rule, {
       `,
     },
 
-    // cases: ternary isn't valid if strategy is only "cast"
+    // cases: ternary isn't valid if strategy is only "coerce"
     {
       code: `
         const Component = ({ count, title }) => {
           return <div>{count ? title : null}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -647,7 +647,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{!count ? title : null}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,
@@ -665,7 +665,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
           return <div>{count && somethingElse ? title : null}</div>
         }
       `,
-      options: [{ validStrategies: ['cast'] }],
+      options: [{ validStrategies: ['coerce'] }],
       errors: [{
         message: 'Potential leaked value that might cause unintentionally rendered values or rendering crashes',
         line: 3,