Skip to content

Commit 3dd1215

Browse files
fix: remove error reporting for empty string for react >=v18
1 parent 6073df0 commit 3dd1215

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

lib/rules/jsx-no-leaked-render.js

+9-7
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
const docsUrl = require('../util/docsUrl');
99
const report = require('../util/report');
10+
const { testReactVersion } = require('../util/version');
1011
const isParenthesized = require('../util/ast').isParenthesized;
1112

1213
//------------------------------------------------------------------------------
@@ -129,13 +130,14 @@ module.exports = {
129130
return;
130131
}
131132
}
132-
133-
report(context, messages.noPotentialLeakedRender, 'noPotentialLeakedRender', {
134-
node,
135-
fix(fixer) {
136-
return ruleFixer(context, fixStrategy, fixer, node, leftSide, node.right);
137-
},
138-
});
133+
if(!testReactVersion(context, '>= 18.0.0') && !(node.left.value == '')){
134+
report(context, messages.noPotentialLeakedRender, 'noPotentialLeakedRender', {
135+
node,
136+
fix(fixer) {
137+
return ruleFixer(context, fixStrategy, fixer, node, leftSide, node.right);
138+
},
139+
});
140+
}
139141
},
140142

141143
'JSXExpressionContainer > ConditionalExpression'(node) {

tests/lib/rules/jsx-no-leaked-render.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ ruleTester.run('jsx-no-leaked-render', rule, {
232232
return (
233233
<>
234234
{0 ? <Something/> : null}
235-
{'' ? <Something/> : null}
235+
{'' && <Something/>}
236236
{NaN ? <Something/> : null}
237237
</>
238238
)

0 commit comments

Comments
 (0)