Merge branch 'eslint'

Author: ljharb

.eslintrc

@@ -1,173 +1,45 @@
 {
+    "root": true,
+    "extends": "airbnb-base",
     "env": {
        "es6": true,
        "node": true
     },
     "parserOptions": {
       "ecmaVersion": 6,
       "ecmaFeatures": {
-          "jsx": true
-      }
+        "jsx": true
+      },
+      "sourceType": "script",
     },
     "rules": {
-        // Possible Errors
         "comma-dangle": [2, "never"],
-        "computed-property-spacing": [2, "never"],
-        "no-cond-assign": 2,
-        "no-console": 2,
-        "no-constant-condition": 2,
-        "no-control-regex": 2,
-        "no-debugger": 2,
-        "no-dupe-keys": 2,
-        "no-empty": 2,
-        "no-empty-character-class": 2,
-        "no-ex-assign": 2,
-        "no-extra-boolean-cast": 2,
-        "no-extra-parens": 0,
-        "no-extra-semi": 2,
-        "no-func-assign": 2,
-        "no-inner-declarations": 2,
-        "no-invalid-regexp": 2,
-        "no-irregular-whitespace": 2,
-        "no-negated-in-lhs": 2,
-        "no-obj-calls": 2,
-        "no-regex-spaces": 2,
-        "no-reserved-keys": 0,
-        "no-sparse-arrays": 2,
-        "no-unreachable": 2,
-        "use-isnan": 2,
-        "valid-jsdoc": 0,
-        "valid-typeof": 2,
-        // Best Practices
-        "block-scoped-var": 2,
-        "complexity": 0,
-        "consistent-return": 2,
-        "curly": 2,
-        "default-case": 2,
-        "dot-notation": 2,
-        "eqeqeq": 2,
-        "guard-for-in": 2,
-        "no-alert": 2,
-        "no-caller": 2,
-        "no-confusing-arrow": 2,
-        "no-div-regex": 2,
-        "no-else-return": 2,
-        "no-eq-null": 2,
-        "no-eval": 2,
-        "no-extend-native": 2,
-        "no-extra-bind": 2,
-        "no-fallthrough": 2,
-        "no-floating-decimal": 2,
-        "no-implied-eval": 2,
-        "no-iterator": 2,
-        "no-labels": 2,
-        "no-lone-blocks": 2,
-        "no-loop-func": 2,
-        "no-multi-spaces": 2,
-        "no-multi-str": 2,
-        "no-native-reassign": 2,
-        "no-new": 2,
-        "no-new-func": 2,
-        "no-new-wrappers": 2,
-        "no-octal": 2,
-        "no-octal-escape": 2,
-        "no-process-env": 2,
-        "no-proto": 2,
-        "no-redeclare": 2,
-        "no-return-assign": 2,
-        "no-script-url": 2,
-        "no-self-compare": 2,
-        "no-sequences": 2,
-        "no-unused-expressions": 2,
-        "no-void": 0,
-        "no-warning-comments": 2,
-        "no-with": 2,
-        "prefer-arrow-callback": 2,
-        "radix": 2,
-        "vars-on-top": 0,
-        "wrap-iife": 2,
-        "yoda": 2,
-        // Strict Mode
-        "strict": [2, "global"],
-        // Variables
-        "prefer-const": 2,
-        "no-catch-shadow": 2,
-        "no-const-assign": 2,
-        "no-delete-var": 2,
-        "no-label-var": 2,
-        "no-shadow": 2,
-        "no-shadow-restricted-names": 2,
-        "no-undef": 2,
-        "no-undef-init": 2,
-        "no-undefined": 2,
-        "no-unused-vars": 2,
-        "no-use-before-define": 2,
-        "no-var": 2,
-        // Stylistic Issues
-        "indent": [2, 2, {
-          "SwitchCase": 1
-        }],
-        "arrow-body-style": [2, "as-needed"],
-        "arrow-parens": [2, "as-needed"],
-        "arrow-spacing": 2,
-        "brace-style": 2,
-        "camelcase": 0,
-        "comma-spacing": 2,
-        "comma-style": 2,
-        "consistent-this": 0,
-        "eol-last": 2,
-        "func-names": 0,
-        "func-style": 0,
-        "key-spacing": [2, {
-          "beforeColon": false,
-          "afterColon": true
-        }],
-        "max-nested-callbacks": 0,
-        "new-cap": 2,
-        "new-parens": 2,
-        "no-array-constructor": 2,
-        "no-inline-comments": 0,
-        "no-lonely-if": 2,
-        "no-mixed-spaces-and-tabs": 2,
-        "no-nested-ternary": 2,
-        "no-new-object": 2,
-        "semi-spacing": [2, {
-          "before": false,
-          "after": true
-        }],
-        "no-spaced-func": 2,
-        "no-ternary": 0,
-        "no-trailing-spaces": 2,
-        "no-multiple-empty-lines": 2,
-        "no-underscore-dangle": 0,
-        "one-var": 0,
-        "operator-assignment": [2, "always"],
-        "padded-blocks": [2, { "blocks": "never", "classes": "never", "switches": "never" }],
-        "quotes": [2, "single"],
-        "quote-props": [2, "as-needed"],
-        "semi": [2, "always"],
-        "sort-vars": [2, {"ignoreCase": true}],
-        "keyword-spacing": 2,
-        "space-before-blocks": 2,
         "object-curly-spacing": [2, "never"],
         "array-bracket-spacing": [2, "never"],
-        "space-in-parens": 2,
-        "space-infix-ops": 2,
-        "space-unary-ops": 2,
-        "spaced-comment": 2,
-        "wrap-regex": 0,
-        // Legacy
-        "max-depth": 0,
         "max-len": [2, 120, {
           "ignoreStrings": true,
           "ignoreTemplateLiterals": true,
           "ignoreComments": true,
         }],
-        "max-params": 0,
-        "max-statements": 0,
-        "no-plusplus": 0,
-        "no-prototype-builtins": 2,
-        "prefer-template": 2,
-        "template-curly-spacing": [2, "never"]
-    }
+        "operator-linebreak": [2, "after"],
+        "consistent-return": 0,
+
+        "prefer-destructuring": [2, { "array": false, "object": false }, { "enforceForRenamedProperties": false }],
+
+        "function-paren-newline": 0,
+        "no-plusplus": 1,
+        "no-param-reassign": 1,
+        "no-mixed-operators": 1,
+        "global-require": 1,
+        "no-restricted-syntax": 1,
+        "valid-jsdoc": 1,
+    },
+    "overrides": [
+      {
+        "files": "tests/**",
+        "rules": {
+          "no-template-curly-in-string": 1,
+        },
+      },
+    ],
 }

index.js

@@ -1,6 +1,7 @@
 'use strict';
 
-const has = require('has');
+const fromEntries = require('object.fromentries');
+const entries = require('object.entries');
 
 const allRules = {
   'boolean-prop-naming': require('./lib/rules/boolean-prop-naming'),
@@ -88,24 +89,11 @@ const allRules = {
 };
 
 function filterRules(rules, predicate) {
-  const result = {};
-  for (const key in rules) {
-    if (has(rules, key) && predicate(rules[key])) {
-      result[key] = rules[key];
-    }
-  }
-  return result;
+  return fromEntries(entries(rules).filter(entry => predicate(entry[1])));
 }
 
 function configureAsError(rules) {
-  const result = {};
-  for (const key in rules) {
-    if (!has(rules, key)) {
-      continue;
-    }
-    result[`react/${key}`] = 2;
-  }
-  return result;
+  return fromEntries(Object.keys(rules).map(key => [`react/${key}`, 2]));
 }
 
 const activeRules = filterRules(allRules, rule => !rule.meta.deprecated);
@@ -114,7 +102,7 @@ const activeRulesConfig = configureAsError(activeRules);
 const deprecatedRules = filterRules(allRules, rule => rule.meta.deprecated);
 
 module.exports = {
-  deprecatedRules: deprecatedRules,
+  deprecatedRules,
   rules: allRules,
   configs: {
     recommended: {