@@ -31,65 +31,65 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
31
31
valid : parsers . all ( [
32
32
{
33
33
code : `
34
- const Component = () => {
35
- return <div>{customTitle || defaultTitle}</div>
36
- }
34
+ const Component = () => {
35
+ return <div>{customTitle || defaultTitle}</div>
36
+ }
37
37
` ,
38
38
} ,
39
39
{
40
40
code : `
41
- const Component = ({ elements }) => {
42
- return <div>{elements}</div>
43
- }
41
+ const Component = ({ elements }) => {
42
+ return <div>{elements}</div>
43
+ }
44
44
` ,
45
45
} ,
46
46
{
47
47
code : `
48
- const Component = ({ elements }) => {
49
- return <div>There are {elements.length} elements</div>
50
- }
48
+ const Component = ({ elements }) => {
49
+ return <div>There are {elements.length} elements</div>
50
+ }
51
51
` ,
52
52
} ,
53
53
{
54
54
code : `
55
- const Component = ({ elements, count }) => {
56
- return <div>{!count && 'No results found'}</div>
57
- }
55
+ const Component = ({ elements, count }) => {
56
+ return <div>{!count && 'No results found'}</div>
57
+ }
58
58
` ,
59
59
} ,
60
60
{
61
61
code : `
62
- const Component = ({ elements }) => {
63
- return <div>{!!elements.length && <List elements={elements}/>}</div>
64
- }
62
+ const Component = ({ elements }) => {
63
+ return <div>{!!elements.length && <List elements={elements}/>}</div>
64
+ }
65
65
` ,
66
66
} ,
67
67
{
68
68
code : `
69
- const Component = ({ elements }) => {
70
- return <div>{Boolean(elements.length) && <List elements={elements}/>}</div>
71
- }
69
+ const Component = ({ elements }) => {
70
+ return <div>{Boolean(elements.length) && <List elements={elements}/>}</div>
71
+ }
72
72
` ,
73
73
} ,
74
74
{
75
75
code : `
76
- const Component = ({ elements }) => {
77
- return <div>{elements.length > 0 && <List elements={elements}/>}</div>
78
- }
76
+ const Component = ({ elements }) => {
77
+ return <div>{elements.length > 0 && <List elements={elements}/>}</div>
78
+ }
79
79
` ,
80
80
} ,
81
81
{
82
82
code : `
83
- const Component = ({ elements }) => {
84
- return <div>{elements.length ? <List elements={elements}/> : null}</div>
85
- }
83
+ const Component = ({ elements }) => {
84
+ return <div>{elements.length ? <List elements={elements}/> : null}</div>
85
+ }
86
86
` ,
87
87
} ,
88
88
{
89
89
code : `
90
- const Component = ({ elements, count }) => {
91
- return <div>{count ? <List elements={elements}/> : null}</div>
92
- }
90
+ const Component = ({ elements, count }) => {
91
+ return <div>{count ? <List elements={elements}/> : null}</div>
92
+ }
93
93
` ,
94
94
} ,
95
95
] ) ,
@@ -98,215 +98,215 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
98
98
// Invalid tests with cast to boolean fix strategy
99
99
{
100
100
code : `
101
- const Component = ({ count, title }) => {
102
- return <div>{count && title}</div>
103
- }
101
+ const Component = ({ count, title }) => {
102
+ return <div>{count && title}</div>
103
+ }
104
104
` ,
105
105
options : [ { fixStrategy : 'cast' } ] ,
106
106
errors : [ {
107
107
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
108
108
line : 3 ,
109
- column : 22 ,
109
+ column : 24 ,
110
110
} ] ,
111
111
output : `
112
- const Component = ({ count, title }) => {
113
- return <div>{!!count && title}</div>
114
- }
112
+ const Component = ({ count, title }) => {
113
+ return <div>{!!count && title}</div>
114
+ }
115
115
` ,
116
116
} ,
117
117
{
118
118
code : `
119
- const Component = ({ count }) => {
120
- return <div>{count && <span>There are {count} results</span>}</div>
121
- }
119
+ const Component = ({ count }) => {
120
+ return <div>{count && <span>There are {count} results</span>}</div>
121
+ }
122
122
` ,
123
123
options : [ { fixStrategy : 'cast' } ] ,
124
124
errors : [ {
125
125
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
126
126
line : 3 ,
127
- column : 22 ,
127
+ column : 24 ,
128
128
} ] ,
129
129
output : `
130
- const Component = ({ count }) => {
131
- return <div>{!!count && <span>There are {count} results</span>}</div>
132
- }
130
+ const Component = ({ count }) => {
131
+ return <div>{!!count && <span>There are {count} results</span>}</div>
132
+ }
133
133
` ,
134
134
} ,
135
135
{
136
136
code : `
137
- const Component = ({ elements }) => {
138
- return <div>{elements.length && <List elements={elements}/>}</div>
139
- }
137
+ const Component = ({ elements }) => {
138
+ return <div>{elements.length && <List elements={elements}/>}</div>
139
+ }
140
140
` ,
141
141
options : [ { fixStrategy : 'cast' } ] ,
142
142
errors : [ {
143
143
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
144
144
line : 3 ,
145
- column : 22 ,
145
+ column : 24 ,
146
146
} ] ,
147
147
output : `
148
- const Component = ({ elements }) => {
149
- return <div>{!!elements.length && <List elements={elements}/>}</div>
150
- }
148
+ const Component = ({ elements }) => {
149
+ return <div>{!!elements.length && <List elements={elements}/>}</div>
150
+ }
151
151
` ,
152
152
} ,
153
153
{
154
154
code : `
155
- const Component = ({ nestedCollection }) => {
156
- return <div>{nestedCollection.elements.length && <List elements={nestedCollection.elements}/>}</div>
157
- }
155
+ const Component = ({ nestedCollection }) => {
156
+ return <div>{nestedCollection.elements.length && <List elements={nestedCollection.elements}/>}</div>
157
+ }
158
158
` ,
159
159
options : [ { fixStrategy : 'cast' } ] ,
160
160
errors : [ {
161
161
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
162
162
line : 3 ,
163
- column : 22 ,
163
+ column : 24 ,
164
164
} ] ,
165
165
output : `
166
- const Component = ({ nestedCollection }) => {
167
- return <div>{!!nestedCollection.elements.length && <List elements={nestedCollection.elements}/>}</div>
168
- }
166
+ const Component = ({ nestedCollection }) => {
167
+ return <div>{!!nestedCollection.elements.length && <List elements={nestedCollection.elements}/>}</div>
168
+ }
169
169
` ,
170
170
} ,
171
171
{
172
172
code : `
173
- const Component = ({ elements }) => {
174
- return <div>{elements[0] && <List elements={elements}/>}</div>
175
- }
173
+ const Component = ({ elements }) => {
174
+ return <div>{elements[0] && <List elements={elements}/>}</div>
175
+ }
176
176
` ,
177
177
options : [ { fixStrategy : 'cast' } ] ,
178
178
errors : [ {
179
179
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
180
180
line : 3 ,
181
- column : 22 ,
181
+ column : 24 ,
182
182
} ] ,
183
183
output : `
184
- const Component = ({ elements }) => {
185
- return <div>{!!elements[0] && <List elements={elements}/>}</div>
186
- }
184
+ const Component = ({ elements }) => {
185
+ return <div>{!!elements[0] && <List elements={elements}/>}</div>
186
+ }
187
187
` ,
188
188
} ,
189
189
{
190
190
code : `
191
- const Component = ({ numberA, numberB }) => {
192
- return <div>{(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
193
- }
191
+ const Component = ({ numberA, numberB }) => {
192
+ return <div>{(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
193
+ }
194
194
` ,
195
195
options : [ { fixStrategy : 'cast' } ] ,
196
196
errors : [ {
197
197
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
198
198
line : 3 ,
199
- column : 23 ,
199
+ column : 25 ,
200
200
} ] ,
201
201
output : `
202
- const Component = ({ numberA, numberB }) => {
203
- return <div>{!!(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
204
- }
202
+ const Component = ({ numberA, numberB }) => {
203
+ return <div>{!!(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
204
+ }
205
205
` ,
206
206
} ,
207
207
208
208
// Invalid tests with ternary fix strategy
209
209
{
210
210
code : `
211
- const Component = ({ count, title }) => {
212
- return <div>{count && title}</div>
213
- }
211
+ const Component = ({ count, title }) => {
212
+ return <div>{count && title}</div>
213
+ }
214
214
` ,
215
215
errors : [ {
216
216
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
217
217
line : 3 ,
218
- column : 22 ,
218
+ column : 24 ,
219
219
} ] ,
220
220
output : `
221
- const Component = ({ count, title }) => {
222
- return <div>{count ? title : null}</div>
223
- }
221
+ const Component = ({ count, title }) => {
222
+ return <div>{count ? title : null}</div>
223
+ }
224
224
` ,
225
225
} ,
226
226
{
227
227
code : `
228
- const Component = ({ count }) => {
229
- return <div>{count && <span>There are {count} results</span>}</div>
230
- }
228
+ const Component = ({ count }) => {
229
+ return <div>{count && <span>There are {count} results</span>}</div>
230
+ }
231
231
` ,
232
232
errors : [ {
233
233
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
234
234
line : 3 ,
235
- column : 22 ,
235
+ column : 24 ,
236
236
} ] ,
237
237
output : `
238
- const Component = ({ count }) => {
239
- return <div>{count ? <span>There are {count} results</span> : null}</div>
240
- }
238
+ const Component = ({ count }) => {
239
+ return <div>{count ? <span>There are {count} results</span> : null}</div>
240
+ }
241
241
` ,
242
242
} ,
243
243
{
244
244
code : `
245
- const Component = ({ elements }) => {
246
- return <div>{elements.length && <List elements={elements}/>}</div>
247
- }
245
+ const Component = ({ elements }) => {
246
+ return <div>{elements.length && <List elements={elements}/>}</div>
247
+ }
248
248
` ,
249
249
errors : [ {
250
250
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
251
251
line : 3 ,
252
- column : 22 ,
252
+ column : 24 ,
253
253
} ] ,
254
254
output : `
255
- const Component = ({ elements }) => {
256
- return <div>{elements.length ? <List elements={elements}/> : null}</div>
257
- }
255
+ const Component = ({ elements }) => {
256
+ return <div>{elements.length ? <List elements={elements}/> : null}</div>
257
+ }
258
258
` ,
259
259
} ,
260
260
{
261
261
code : `
262
- const Component = ({ nestedCollection }) => {
263
- return <div>{nestedCollection.elements.length && <List elements={nestedCollection.elements}/>}</div>
264
- }
262
+ const Component = ({ nestedCollection }) => {
263
+ return <div>{nestedCollection.elements.length && <List elements={nestedCollection.elements}/>}</div>
264
+ }
265
265
` ,
266
266
errors : [ {
267
267
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
268
268
line : 3 ,
269
- column : 22 ,
269
+ column : 24 ,
270
270
} ] ,
271
271
output : `
272
- const Component = ({ nestedCollection }) => {
273
- return <div>{nestedCollection.elements.length ? <List elements={nestedCollection.elements}/> : null}</div>
274
- }
272
+ const Component = ({ nestedCollection }) => {
273
+ return <div>{nestedCollection.elements.length ? <List elements={nestedCollection.elements}/> : null}</div>
274
+ }
275
275
` ,
276
276
} ,
277
277
{
278
278
code : `
279
- const Component = ({ elements }) => {
280
- return <div>{elements[0] && <List elements={elements}/>}</div>
281
- }
279
+ const Component = ({ elements }) => {
280
+ return <div>{elements[0] && <List elements={elements}/>}</div>
281
+ }
282
282
` ,
283
283
errors : [ {
284
284
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
285
285
line : 3 ,
286
- column : 22 ,
286
+ column : 24 ,
287
287
} ] ,
288
288
output : `
289
- const Component = ({ elements }) => {
290
- return <div>{elements[0] ? <List elements={elements}/> : null}</div>
291
- }
289
+ const Component = ({ elements }) => {
290
+ return <div>{elements[0] ? <List elements={elements}/> : null}</div>
291
+ }
292
292
` ,
293
293
} ,
294
294
{
295
295
code : `
296
- const Component = ({ numberA, numberB }) => {
297
- return <div>{(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
298
- }
296
+ const Component = ({ numberA, numberB }) => {
297
+ return <div>{(numberA || numberB) && <Results>{numberA+numberB}</Results>}</div>
298
+ }
299
299
` ,
300
300
options : [ { fixStrategy : 'ternary' } ] ,
301
301
errors : [ {
302
302
message : 'Potential numeric evaluation resulting in an unintentionally rendered `0`' ,
303
303
line : 3 ,
304
- column : 23 ,
304
+ column : 25 ,
305
305
} ] ,
306
306
output : `
307
- const Component = ({ numberA, numberB }) => {
308
- return <div>{(numberA || numberB) ? <Results>{numberA+numberB}</Results> : null}</div>
309
- }
307
+ const Component = ({ numberA, numberB }) => {
308
+ return <div>{(numberA || numberB) ? <Results>{numberA+numberB}</Results> : null}</div>
309
+ }
310
310
` ,
311
311
} ,
312
312
] ) ,
0 commit comments