Skip to content

Commit 3b56239

Browse files
committed
Merge pull request #456 from jkimbo/false-positive-jsx-key-rule
Fix false positive in jsx-key
2 parents c392099 + 0d2d162 commit 3b56239

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/rules/jsx-key.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ module.exports = function(context) {
5252

5353
// Array.prototype.map
5454
CallExpression: function (node) {
55+
if (node.callee && node.callee.type !== 'MemberExpression') {
56+
return;
57+
}
58+
5559
if (node.callee && node.callee.property && node.callee.property.name !== 'map') {
5660
return;
5761
}

tests/lib/rules/jsx-key.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ ruleTester.run('jsx-key', rule, {
3434
{code: '[1, 2, 3].map(x => { return <App key={x} /> });', parserOptions: parserOptions},
3535
{code: '[1, 2, 3].foo(x => <App />);', parserOptions: parserOptions},
3636
{code: 'var App = () => <div />;', parserOptions: parserOptions},
37-
{code: '[1, 2, 3].map(function(x) { return; });', parserOptions: parserOptions}
37+
{code: '[1, 2, 3].map(function(x) { return; });', parserOptions: parserOptions},
38+
{code: 'foo(() => <div />);', parserOptions: parserOptions}
3839
],
3940
invalid: [
4041
{code: '[<App />];',

0 commit comments

Comments
 (0)