Apply suggestion: replace mutation with Object.assign

golopot · ljharb · web-flow · commit 3a1a0d1d159e · 2019-06-12T15:08:58.000+08:00
Co-Authored-By: Jordan Harband &lt;ljharb@gmail.com&gt;
diff --git a/lib/util/usedPropTypes.js b/lib/util/usedPropTypes.js
@@ -39,7 +39,7 @@ function createPropVariables() {
       if (!hasBeenWritten) {
         // copy on write
         propVariables = new Map(propVariables);
-        stack[stack.length - 1].propVariables = propVariables;
+        Object.assign(stack[stack.length - 1], { propVariables, hasBeenWritten: true });
         stack[stack.length - 1].hasBeenWritten = true;
       }
       return propVariables.set(name, allNames);

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ function createPropVariables() {`
`39`	`39`	`if (!hasBeenWritten) {`
`40`	`40`	`// copy on write`
`41`	`41`	`propVariables = new Map(propVariables);`
`42`		`- stack[stack.length - 1].propVariables = propVariables;`
	`42`	`+ Object.assign(stack[stack.length - 1], { propVariables, hasBeenWritten: true });`
`43`	`43`	`stack[stack.length - 1].hasBeenWritten = true;`
`44`	`44`	`}`
`45`	`45`	`return propVariables.set(name, allNames);`