Skip to content

Commit 2929aaa

Browse files
committed
Fix classes with properties to always be marked as components (fixes #291)
1 parent a09ac73 commit 2929aaa

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

lib/util/Components.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ function componentRule(rule, context) {
206206
scope = scope.upper;
207207
}
208208
var node = scope && scope.block;
209-
if (!node || !node.superClass) {
209+
if (!node || !context.react.isES6Component(node)) {
210210
return null;
211211
}
212212
return node;

tests/lib/rules/display-name.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,16 @@ ruleTester.run('display-name', rule, {
5757
classes: true,
5858
jsx: true
5959
}
60+
}, {
61+
code: [
62+
'class Hello extends Greetings {',
63+
' static text = \'Hello World\';',
64+
' render() {',
65+
' return Hello.text;',
66+
' }',
67+
'}'
68+
].join('\n'),
69+
parser: 'babel-eslint'
6070
}, {
6171
code: [
6272
'class Hello {',

0 commit comments

Comments
 (0)