Apply suggestions from code review

Co-authored-by: Jordan Harband <[email protected]>

Author: jaesoekjjang

lib/rules/checked-requires-onchange-or-readonly.js

@@ -27,7 +27,6 @@ function extractTargetProps(properties, keyName) {
   return properties.reduce((acc, prop) => {
     if (
       prop[keyName]
-      && prop[keyName].name
       && targetPropSet.has(prop[keyName].name)
     ) {
       acc.add(prop[keyName].name);
@@ -39,8 +38,7 @@ function extractTargetProps(properties, keyName) {
 module.exports = {
   meta: {
     docs: {
-      description:
-        'Enforce using `onChange` or `readonly` attribute when `checked` is used',
+      description: 'Enforce using `onChange` or `readonly` attribute when `checked` is used',
       category: 'Best Practices',
       recommended: false,
       url: docsUrl('checked-requires-onchange-or-readonly'),
@@ -115,7 +113,9 @@ module.exports = {
           return;
         }
 
-        if (!secondArg || secondArg.type !== 'ObjectExpression') return;
+        if (!secondArg || secondArg.type !== 'ObjectExpression') {
+          return;
+        }
 
         const propSet = extractTargetProps(secondArg.properties, 'key');
         checkAttributesAndReport(node, propSet);

tests/lib/rules/checked-requires-onchange-or-readonly.js

@@ -23,15 +23,15 @@ const ruleTester = new RuleTester({
 ruleTester.run('checked-requires-onchange-or-readonly', rule, {
   valid: parsers.all([
     '<input type="checkbox" />',
-    '<input type="checkbox" onChange={noop}/>',
-    '<input type="checkbox" readOnly/>',
+    '<input type="checkbox" onChange={noop} />',
+    '<input type="checkbox" readOnly />',
     '<input type="checkbox" checked onChange={noop} />',
-    '<input type="checkbox" checked readOnly/>',
-    '<input type="checkbox" defaultChecked/>',
-    "React.createElement('input', {checked: true, onChange: noop})",
-    "React.createElement('input', {checked: false, onChange: noop})",
-    "React.createElement('input', {checked: true, readOnly: true})",
-    "React.createElement('input', {checked: true, onChange: noop, readOnly: true})",
+    '<input type="checkbox" checked readOnly />',
+    '<input type="checkbox" defaultChecked />',
+    "React.createElement('input', { checked: true, onChange: noop })",
+    "React.createElement('input', { checked: false, onChange: noop })",
+    "React.createElement('input', { checked: true, readOnly: true })",
+    "React.createElement('input', { checked: true, onChange: noop, readOnly: true })",
     {
       code: '<input type="checkbox" checked />',
       options: [{ ignoreMissingProperties: false }],