Skip to content

Commit 1c0c92b

Browse files
sjarvaljharb
authored andcommitted
[Fix] no-unknown-property: Add more one word properties found in DefinitelyTyped's react/index.d.ts
Manifest, summary, wmode, results, security
1 parent 32119f9 commit 1c0c92b

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
1111
* [`no-unknown-property`]: allow `webkitAllowFullScreen` and `mozAllowFullScreen` ([#3396][] @ljharb)
1212
* [`no-unknown-property`]: `controlsList`, not `controlList` ([#3397][] @ljharb)
1313
* [`no-unknown-property`]: add more capture event properties ([#3402][] @sjarva)
14+
* [`no-unknown-property`]: Add more one word properties found in DefinitelyTyped's react/index.d.ts ([#3402][] @sjarva)
1415

1516
[#3402]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3402
1617
[#3397]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3397

lib/rules/no-unknown-property.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,10 @@ const DOM_PROPERTY_NAMES_ONE_WORD = [
194194
'accept', 'action', 'allow', 'alt', 'as', 'async', 'buffered', 'capture', 'challenge', 'cite', 'code', 'cols',
195195
'content', 'coords', 'csp', 'data', 'decoding', 'default', 'defer', 'disabled', 'form',
196196
'headers', 'height', 'high', 'href', 'icon', 'importance', 'integrity', 'kind', 'label',
197-
'language', 'loading', 'list', 'loop', 'low', 'max', 'media', 'method', 'min', 'multiple', 'muted',
197+
'language', 'loading', 'list', 'loop', 'low', 'manifest', 'max', 'media', 'method', 'min', 'multiple', 'muted',
198198
'name', 'open', 'optimum', 'pattern', 'ping', 'placeholder', 'poster', 'preload', 'profile',
199-
'rel', 'required', 'reversed', 'role', 'rows', 'sandbox', 'scope', 'selected', 'shape', 'size', 'sizes',
200-
'span', 'src', 'start', 'step', 'target', 'type', 'value', 'width', 'wrap',
199+
'rel', 'required', 'reversed', 'role', 'rows', 'sandbox', 'scope', 'seamless', 'selected', 'shape', 'size', 'sizes',
200+
'span', 'src', 'start', 'step', 'summary', 'target', 'type', 'value', 'width', 'wmode', 'wrap',
201201
// SVG attributes
202202
// See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute
203203
'accumulate', 'additive', 'alphabetic', 'amplitude', 'ascent', 'azimuth', 'bbox', 'begin',
@@ -214,6 +214,8 @@ const DOM_PROPERTY_NAMES_ONE_WORD = [
214214
'property',
215215
// React specific attributes
216216
'ref', 'key', 'children',
217+
// Non-standard
218+
'results', 'security',
217219
// Video specific
218220
'controls',
219221
];

0 commit comments

Comments
 (0)