Skip to content

Commit 0aeebaf

Browse files
committed
Fix sort-comp crash on spread operator (fixes #624)
1 parent aa359fb commit 0aeebaf

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

lib/rules/sort-comp.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,9 @@ module.exports = Components.detect(function(context, components) {
247247
case 'ClassDeclaration':
248248
return node.body.body;
249249
case 'ObjectExpression':
250-
return node.properties;
250+
return node.properties.filter(function(property) {
251+
return property.type === 'Property';
252+
});
251253
default:
252254
return [];
253255
}

tests/lib/rules/sort-comp.js

+11
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,17 @@ ruleTester.run('sort-comp', rule, {
192192
')'
193193
].join('\n'),
194194
parser: 'babel-eslint'
195+
}, {
196+
// Must ignore spread operator
197+
code: [
198+
'var Hello = React.createClass({',
199+
' ...proto,',
200+
' render: function() {',
201+
' return <div>Hello</div>;',
202+
' }',
203+
'});'
204+
].join('\n'),
205+
parser: 'babel-eslint'
195206
}],
196207

197208
invalid: [{

0 commit comments

Comments
 (0)