Skip to content

Commit 063e343

Browse files
pfhayesyannickcr
authored andcommitted
Add an "all" sharable configuration with all rules enabled (fixes #674)
1 parent 55b9cbe commit 063e343

File tree

3 files changed

+92
-49
lines changed

3 files changed

+92
-49
lines changed

README.md

+12
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,18 @@ To enable this configuration use the `extends` property in your `.eslintrc` conf
149149
}
150150
```
151151

152+
This plugin also exports an `all` configuration that includes every available rule.
153+
This pairs well with the `eslint:all` rule.
154+
155+
```js
156+
{
157+
"plugins": [
158+
"react"
159+
],
160+
"extends": ["eslint:all", "plugin:react/all"]
161+
}
162+
```
163+
152164
See [ESLint documentation](http://eslint.org/docs/user-guide/configuring#extending-configuration-files) for more information about extending configuration files.
153165

154166
The rules enabled in this configuration are:

index.js

+65-49
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,63 @@
11
'use strict';
22

3+
var rules = {
4+
'jsx-uses-react': require('./lib/rules/jsx-uses-react'),
5+
'no-multi-comp': require('./lib/rules/no-multi-comp'),
6+
'prop-types': require('./lib/rules/prop-types'),
7+
'display-name': require('./lib/rules/display-name'),
8+
'wrap-multilines': require('./lib/rules/wrap-multilines'),
9+
'self-closing-comp': require('./lib/rules/self-closing-comp'),
10+
'no-comment-textnodes': require('./lib/rules/no-comment-textnodes'),
11+
'no-danger': require('./lib/rules/no-danger'),
12+
'no-set-state': require('./lib/rules/no-set-state'),
13+
'no-is-mounted': require('./lib/rules/no-is-mounted'),
14+
'no-deprecated': require('./lib/rules/no-deprecated'),
15+
'no-did-mount-set-state': require('./lib/rules/no-did-mount-set-state'),
16+
'no-did-update-set-state': require('./lib/rules/no-did-update-set-state'),
17+
'no-render-return-value': require('./lib/rules/no-render-return-value'),
18+
'react-in-jsx-scope': require('./lib/rules/react-in-jsx-scope'),
19+
'jsx-uses-vars': require('./lib/rules/jsx-uses-vars'),
20+
'jsx-handler-names': require('./lib/rules/jsx-handler-names'),
21+
'jsx-pascal-case': require('./lib/rules/jsx-pascal-case'),
22+
'jsx-no-bind': require('./lib/rules/jsx-no-bind'),
23+
'jsx-no-undef': require('./lib/rules/jsx-no-undef'),
24+
'no-unknown-property': require('./lib/rules/no-unknown-property'),
25+
'jsx-curly-spacing': require('./lib/rules/jsx-curly-spacing'),
26+
'jsx-equals-spacing': require('./lib/rules/jsx-equals-spacing'),
27+
'jsx-sort-props': require('./lib/rules/jsx-sort-props'),
28+
'sort-prop-types': require('./lib/rules/sort-prop-types'),
29+
'jsx-boolean-value': require('./lib/rules/jsx-boolean-value'),
30+
'sort-comp': require('./lib/rules/sort-comp'),
31+
'require-extension': require('./lib/rules/require-extension'),
32+
'jsx-no-duplicate-props': require('./lib/rules/jsx-no-duplicate-props'),
33+
'jsx-max-props-per-line': require('./lib/rules/jsx-max-props-per-line'),
34+
'jsx-no-literals': require('./lib/rules/jsx-no-literals'),
35+
'jsx-indent-props': require('./lib/rules/jsx-indent-props'),
36+
'jsx-indent': require('./lib/rules/jsx-indent'),
37+
'jsx-closing-bracket-location': require('./lib/rules/jsx-closing-bracket-location'),
38+
'jsx-space-before-closing': require('./lib/rules/jsx-space-before-closing'),
39+
'no-direct-mutation-state': require('./lib/rules/no-direct-mutation-state'),
40+
'forbid-prop-types': require('./lib/rules/forbid-prop-types'),
41+
'prefer-es6-class': require('./lib/rules/prefer-es6-class'),
42+
'jsx-key': require('./lib/rules/jsx-key'),
43+
'no-string-refs': require('./lib/rules/no-string-refs'),
44+
'prefer-stateless-function': require('./lib/rules/prefer-stateless-function'),
45+
'require-render-return': require('./lib/rules/require-render-return'),
46+
'jsx-first-prop-new-line': require('./lib/rules/jsx-first-prop-new-line'),
47+
'jsx-no-target-blank': require('./lib/rules/jsx-no-target-blank'),
48+
'jsx-filename-extension': require('./lib/rules/jsx-filename-extension'),
49+
'require-optimization': require('./lib/rules/require-optimization'),
50+
'no-find-dom-node': require('./lib/rules/no-find-dom-node')
51+
};
52+
53+
var ruleNames = Object.keys(rules);
54+
var allRules = {};
55+
for (var i = 0; i < ruleNames.length; i++) {
56+
allRules['react/' + ruleNames[i]] = 2;
57+
}
58+
359
module.exports = {
4-
rules: {
5-
'jsx-uses-react': require('./lib/rules/jsx-uses-react'),
6-
'no-multi-comp': require('./lib/rules/no-multi-comp'),
7-
'prop-types': require('./lib/rules/prop-types'),
8-
'display-name': require('./lib/rules/display-name'),
9-
'wrap-multilines': require('./lib/rules/wrap-multilines'),
10-
'self-closing-comp': require('./lib/rules/self-closing-comp'),
11-
'no-comment-textnodes': require('./lib/rules/no-comment-textnodes'),
12-
'no-danger': require('./lib/rules/no-danger'),
13-
'no-set-state': require('./lib/rules/no-set-state'),
14-
'no-is-mounted': require('./lib/rules/no-is-mounted'),
15-
'no-deprecated': require('./lib/rules/no-deprecated'),
16-
'no-did-mount-set-state': require('./lib/rules/no-did-mount-set-state'),
17-
'no-did-update-set-state': require('./lib/rules/no-did-update-set-state'),
18-
'no-render-return-value': require('./lib/rules/no-render-return-value'),
19-
'react-in-jsx-scope': require('./lib/rules/react-in-jsx-scope'),
20-
'jsx-uses-vars': require('./lib/rules/jsx-uses-vars'),
21-
'jsx-handler-names': require('./lib/rules/jsx-handler-names'),
22-
'jsx-pascal-case': require('./lib/rules/jsx-pascal-case'),
23-
'jsx-no-bind': require('./lib/rules/jsx-no-bind'),
24-
'jsx-no-undef': require('./lib/rules/jsx-no-undef'),
25-
'no-unknown-property': require('./lib/rules/no-unknown-property'),
26-
'jsx-curly-spacing': require('./lib/rules/jsx-curly-spacing'),
27-
'jsx-equals-spacing': require('./lib/rules/jsx-equals-spacing'),
28-
'jsx-sort-props': require('./lib/rules/jsx-sort-props'),
29-
'sort-prop-types': require('./lib/rules/sort-prop-types'),
30-
'jsx-boolean-value': require('./lib/rules/jsx-boolean-value'),
31-
'sort-comp': require('./lib/rules/sort-comp'),
32-
'require-extension': require('./lib/rules/require-extension'),
33-
'jsx-no-duplicate-props': require('./lib/rules/jsx-no-duplicate-props'),
34-
'jsx-max-props-per-line': require('./lib/rules/jsx-max-props-per-line'),
35-
'jsx-no-literals': require('./lib/rules/jsx-no-literals'),
36-
'jsx-indent-props': require('./lib/rules/jsx-indent-props'),
37-
'jsx-indent': require('./lib/rules/jsx-indent'),
38-
'jsx-closing-bracket-location': require('./lib/rules/jsx-closing-bracket-location'),
39-
'jsx-space-before-closing': require('./lib/rules/jsx-space-before-closing'),
40-
'no-direct-mutation-state': require('./lib/rules/no-direct-mutation-state'),
41-
'forbid-prop-types': require('./lib/rules/forbid-prop-types'),
42-
'prefer-es6-class': require('./lib/rules/prefer-es6-class'),
43-
'jsx-key': require('./lib/rules/jsx-key'),
44-
'no-string-refs': require('./lib/rules/no-string-refs'),
45-
'prefer-stateless-function': require('./lib/rules/prefer-stateless-function'),
46-
'require-render-return': require('./lib/rules/require-render-return'),
47-
'jsx-first-prop-new-line': require('./lib/rules/jsx-first-prop-new-line'),
48-
'jsx-no-target-blank': require('./lib/rules/jsx-no-target-blank'),
49-
'jsx-filename-extension': require('./lib/rules/jsx-filename-extension'),
50-
'require-optimization': require('./lib/rules/require-optimization'),
51-
'no-find-dom-node': require('./lib/rules/no-find-dom-node')
52-
},
60+
rules: rules,
5361
configs: {
5462
recommended: {
5563
parserOptions: {
@@ -75,6 +83,14 @@ module.exports = {
7583
'react/prop-types': 2,
7684
'react/react-in-jsx-scope': 2
7785
}
86+
},
87+
all: {
88+
parserOptions: {
89+
ecmaFeatures: {
90+
jsx: true
91+
}
92+
},
93+
rules: allRules
7894
}
7995
}
8096
};

tests/index.js

+15
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,20 @@ describe('all rule files should be exported by the plugin', function() {
2626
describe('configurations', function() {
2727
it('should export a \'recommended\' configuration', function() {
2828
assert(plugin.configs.recommended);
29+
Object.keys(plugin.configs.recommended.rules).forEach(function (configName) {
30+
assert.equal(configName.indexOf('react/'), 0);
31+
var ruleName = configName.substring('react/'.length);
32+
assert(plugin.rules[ruleName]);
33+
});
34+
});
35+
it('should export a \'all\' configuration', function() {
36+
assert(plugin.configs.all);
37+
Object.keys(plugin.configs.all.rules).forEach(function(configName) {
38+
assert.equal(configName.indexOf('react/'), 0);
39+
assert.equal(plugin.configs.all.rules[configName], 2);
40+
});
41+
rules.forEach(function(ruleName) {
42+
assert(plugin.configs.all.rules['react/' + ruleName]);
43+
});
2944
});
3045
});

0 commit comments

Comments
 (0)