Merge pull request #705 from jsx-eslint/fix-heading-error

jessebeach · web-flow · commit b82b1bdf95ff · 2020-06-19T13:45:04.000-07:00
Fix aria-level error for the heading role (#704)
diff --git a/__tests__/src/rules/role-supports-aria-props-test.js b/__tests__/src/rules/role-supports-aria-props-test.js
@@ -381,6 +381,8 @@ ruleTester.run('role-supports-aria-props', rule, {
     { code: '<textarea aria-hidden />' },
     { code: '<select aria-expanded />' },
     { code: '<datalist aria-expanded />' },
+    { code: '<div role="heading" aria-level />' },
+    { code: '<div role="heading" aria-level="1" />' },
 
   ].concat(validTests).map(parserOptionsMapper),
 
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
   "license": "MIT",
   "dependencies": {
     "@babel/runtime": "^7.10.2",
-    "aria-query": "^4.2.0",
+    "aria-query": "^4.2.2",
     "array-includes": "^3.1.1",
     "ast-types-flow": "^0.0.7",
     "axe-core": "^3.5.4",
diff --git a/src/util/isNonInteractiveElement.js b/src/util/isNonInteractiveElement.js
@@ -149,6 +149,13 @@ const isNonInteractiveElement = (
   if (!dom.has(tagName)) {
     return false;
   }
+  // <header> elements do not technically have semantics, unless the
+  // element is a direct descendant of <body>, and this plugin cannot
+  // reliably test that.
+  // @see https://www.w3.org/TR/wai-aria-practices/examples/landmarks/banner.html
+  if (tagName === 'header') {
+    return false;
+  }
 
   return checkIsNonInteractiveElement(tagName, attributes);
 };
