Skip to content

Commit 965e7f0

Browse files
khiga8ljharb
authored andcommitted
bug: fix summary being treated as non-interactive
1 parent 961817f commit 965e7f0

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

__mocks__/genInteractives.js

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ const interactiveElementsMap = {
4949
menuitem: [],
5050
option: [],
5151
select: [],
52+
summary: [],
5253
// Whereas ARIA makes a distinction between cell and gridcell, the AXObject
5354
// treats them both as CellRole and since gridcell is interactive, we consider
5455
// cell interactive as well.

__tests__/src/rules/no-static-element-interactions-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ const alwaysValid = [
8686
{ code: '<form onClick={() => {}} />;' },
8787
{ code: '<form onSubmit={() => {}} />;' },
8888
{ code: '<link onClick={() => {}} href="#" />;' },
89+
{ code: '<summary onClick={() => {}} />;' },
8990
/* HTML elements attributed with an interactive role */
9091
{ code: '<div role="button" onClick={() => {}} />;' },
9192
{ code: '<div role="checkbox" onClick={() => {}} />;' },
@@ -340,7 +341,6 @@ const neverValid = [
340341
{ code: '<style onClick={() => {}} />;', errors: [expectedError] },
341342
{ code: '<sub onClick={() => {}} />;', errors: [expectedError] },
342343
{ code: '<sup onClick={() => {}} />;', errors: [expectedError] },
343-
{ code: '<summary onClick={() => {}} />;', errors: [expectedError] },
344344
{ code: '<title onClick={() => {}} />;', errors: [expectedError] },
345345
{ code: '<track onClick={() => {}} />;', errors: [expectedError] },
346346
{ code: '<tt onClick={() => {}} />;', errors: [expectedError] },

0 commit comments

Comments
 (0)