Skip to content

Commit 651366c

Browse files
qw-inbeefancohen
authored andcommitted
Make aria-role case sensitive
1 parent 56d3b9a commit 651366c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

__tests__/src/rules/aria-role-test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,14 @@ ruleTester.run('aria-role', rule, {
6666
{ code: '<div role="foobar" />', errors: [errorMessage] },
6767
{ code: '<div role="datepicker"></div>', errors: [errorMessage] },
6868
{ code: '<div role="range"></div>', errors: [errorMessage] },
69+
{ code: '<div role="Button"></div>', errors: [errorMessage] },
6970
{ code: '<div role=""></div>', errors: [errorMessage] },
7071
{ code: '<div role="tabpanel row foobar"></div>', errors: [errorMessage] },
7172
{ code: '<div role="tabpanel row range"></div>', errors: [errorMessage] },
7273
{ code: '<div role="doc-endnotes range"></div>', errors: [errorMessage] },
7374
{ code: '<div role />', errors: [errorMessage] },
7475
{ code: '<div role={null}></div>', errors: [errorMessage] },
7576
{ code: '<Foo role="datepicker" />', errors: [errorMessage] },
77+
{ code: '<Foo role="Button" />', errors: [errorMessage] },
7678
].concat(invalidTests).map(parserOptionsMapper),
7779
});

src/rules/aria-role.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module.exports = {
5454
// value isn't in the form of a literal.
5555
if (value === undefined || value === null) { return; }
5656

57-
const normalizedValues = String(value).toLowerCase().split(' ');
57+
const normalizedValues = String(value).split(' ');
5858
const validRoles = [...roles.keys()].filter(role => roles.get(role).abstract === false);
5959
const isValid = normalizedValues.every(val => validRoles.indexOf(val) > -1);
6060

0 commit comments

Comments
 (0)