Merge pull request #660 from tanmoyopenroot/657-fix-mouse-event

fix(mouse-event): remove check from custom elements

Author: jessebeach

__tests__/src/rules/mouse-events-have-key-events-test.js

@@ -39,10 +39,21 @@ ruleTester.run('mouse-events-have-key-events', rule, {
       code: '<div onMouseOver={handleMouseOver} onFocus={handleFocus} {...props} />;',
     },
     { code: '<div />;' },
+    { code: '<div onBlur={() => {}} />' },
+    { code: '<div onFocus={() => {}} />' },
     { code: '<div onMouseOut={() => void 0} onBlur={() => void 0} />' },
     { code: '<div onMouseOut={() => void 0} onBlur={() => void 0} {...props} />' },
     { code: '<div onMouseOut={handleMouseOut} onBlur={handleOnBlur} />' },
     { code: '<div onMouseOut={handleMouseOut} onBlur={handleOnBlur} {...props} />' },
+    { code: '<MyElement />' },
+    { code: '<MyElement onMouseOver={() => {}} />' },
+    { code: '<MyElement onMouseOut={() => {}} />' },
+    { code: '<MyElement onBlur={() => {}} />' },
+    { code: '<MyElement onFocus={() => {}} />' },
+    { code: '<MyElement onMouseOver={() => {}} {...props} />' },
+    { code: '<MyElement onMouseOut={() => {}} {...props} />' },
+    { code: '<MyElement onBlur={() => {}} {...props} />' },
+    { code: '<MyElement onFocus={() => {}} {...props} />' },
   ].map(parserOptionsMapper),
   invalid: [
     { code: '<div onMouseOver={() => void 0} />;', errors: [mouseOverError] },

src/rules/mouse-events-have-key-events.js

@@ -8,6 +8,7 @@
 // Rule Definition
 // ----------------------------------------------------------------------------
 
+import { dom } from 'aria-query';
 import { getProp, getPropValue } from 'jsx-ast-utils';
 import { generateObjSchema } from '../util/schemas';
 
@@ -26,6 +27,12 @@ module.exports = {
 
   create: (context) => ({
     JSXOpeningElement: (node) => {
+      const { name } = node.name;
+
+      if (!dom.get(name)) {
+        return;
+      }
+
       const { attributes } = node;
 
       // Check onmouseover / onfocus pairing.