Skip to content

Commit 0c8880d

Browse files
authored
Merge pull request #695 from jsx-eslint/account-for-generic-role
Account for the new `generic` role in ARIA 1.2
2 parents 0f7cc42 + 97547b1 commit 0c8880d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/util/isNonInteractiveElement.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ const nonInteractiveRoles = new Set(roleKeys
2626
// 'toolbar' does not descend from widget, but it does support
2727
// aria-activedescendant, thus in practice we treat it as a widget.
2828
&& name !== 'toolbar'
29+
// This role is meant to have no semantic value.
30+
// @see https://www.w3.org/TR/wai-aria-1.2/#generic
31+
&& name !== 'generic'
2932
&& !role.superClass.some((classes) => includes(classes, 'widget'))
3033
);
3134
}).concat(
@@ -42,6 +45,9 @@ const interactiveRoles = new Set(roleKeys
4245
// The `progressbar` is descended from `widget`, but in practice, its
4346
// value is always `readonly`, so we treat it as a non-interactive role.
4447
&& name !== 'progressbar'
48+
// This role is meant to have no semantic value.
49+
// @see https://www.w3.org/TR/wai-aria-1.2/#generic
50+
&& name !== 'generic'
4551
&& role.superClass.some((classes) => includes(classes, 'widget'))
4652
);
4753
}).concat(

0 commit comments

Comments
 (0)