refactor: remove unneeded return

DannyvdSluijs · DannyvdSluijs · commit c9ae357587b0 · 2025-05-27T21:45:23.000+02:00
diff --git a/tests/JsonSchemaTestSuiteTest.php b/tests/JsonSchemaTestSuiteTest.php
@@ -39,15 +39,13 @@ public function testTestCaseValidatesCorrectly(
         } catch (\Exception $e) {
             if ($optional) {
                 $this->markTestSkipped('Optional test case would during validate() invocation');
-                return;
             }
 
             throw $e;
         }
 
         if ($optional && $expectedValidationResult !== (count($validator->getErrors()) === 0)) {
             $this->markTestSkipped('Optional test case would fail');
-            return;
         }
 
         self::assertEquals($expectedValidationResult, count($validator->getErrors()) === 0);

Original file line number	Diff line number	Diff line change
`@@ -39,15 +39,13 @@ public function testTestCaseValidatesCorrectly(`
`39`	`39`	`} catch (\Exception $e) {`
`40`	`40`	`if ($optional) {`
`41`	`41`	`$this->markTestSkipped('Optional test case would during validate() invocation');`
`42`		`- return;`
`43`	`42`	`}`
`44`	`43`
`45`	`44`	`throw $e;`
`46`	`45`	`}`
`47`	`46`
`48`	`47`	`if ($optional && $expectedValidationResult !== (count($validator->getErrors()) === 0)) {`
`49`	`48`	`$this->markTestSkipped('Optional test case would fail');`
`50`		`- return;`
`51`	`49`	`}`
`52`	`50`
`53`	`51`	`self::assertEquals($expectedValidationResult, count($validator->getErrors()) === 0);`