Skip to content

spec: 3rd link in example removed but still referenced #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
handrews opened this issue Oct 12, 2016 · 5 comments
Closed

spec: 3rd link in example removed but still referenced #91

handrews opened this issue Oct 12, 2016 · 5 comments

Comments

@handrews
Copy link
Contributor

This line:

https://github.com/json-schema-org/json-schema-spec/blob/master/jsonschema-hyperschema.xml#L298

references a third link in the example immediately above. However, there are only two links (but there was a third in Draft 04). The link should either be added back or the reference removed.

@handrews
Copy link
Contributor Author

If the third link is restored, then it would need to change its method value from "POST" to "post", and the reference would need to be more clear that "post" does not indicate that an HTTP POST should necessarily be used.

@awwright
Copy link
Member

Check that this seems fixed in master

@handrews
Copy link
Contributor Author

I see that you removed the entire example? That does fix this problem, although I think that having examples of some sort would be useful. I need to read through all of the changes so if I still think it needs an example after I do that I can open a new issue.

@awwright
Copy link
Member

I mean, it's a link relation. How many examples do we need?

@handrews
Copy link
Contributor Author

I mean, it's a link relation. How many examples do we need?

Good point, we really don't need that many in the spec. We could develop the examples on the web site further but that's not urgent, and would be a separate issue anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants