Skip to content

Contributing guide file is outdated #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Relequestual opened this issue Jun 15, 2023 · 1 comment · Fixed by #1416
Closed

Contributing guide file is outdated #1414

Relequestual opened this issue Jun 15, 2023 · 1 comment · Fixed by #1416
Assignees
@benjagm

Comments

@Relequestual
Copy link
Member

The contributing guide file located at
https://github.com/json-schema-org/json-schema-spec/blob/main/CONTRIBUTING.md is out of date, and not accurate for how we are proceeding.

We should do one of the following

  • Add a note to the top which states this fact
  • Remove the content that is outdated
  • Start the file from scratch based on our current understanding

This file will require review again once we publish the next version of the specification.
@Relequestual Relequestual added the agenda For the OCWM agenda label Jun 15, 2023
@benjagm benjagm mentioned this issue Jun 18, 2023
Closed
3 tasks
benjagm added a commit that referenced this issue Jun 20, 2023
@benjagm
Update CONTRIBUTING.md to remove outdated information
c0382ec 
Summary: This file is a brand new version of the contributing file to remove outdate information.

Related issue: #1414
@benjagm benjagm mentioned this issue Jun 20, 2023
Merged
@benjagm benjagm removed the agenda For the OCWM agenda label Jun 20, 2023
@benjagm
Copy link
Collaborator

benjagm commented Jun 20, 2023

I just opened a PR with a new version of the contributing guidelines of the Spec and I'd love to get feedback and reviews.

@benjagm benjagm self-assigned this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjagm benjagm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CONTRIBUTING.md to remove outdated information json-schema-org/json-schema-spec
3 participants
@Relequestual @benjagm and others