Skip to content

Commit ff8f074

Browse files
committed
update adr with results of vote
1 parent 1b0e4bb commit ff8f074

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

adr/2024-11-2-assertion-format.md

+8-4
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@
22

33
* Status: proposed
44
<!-- will update below to only those who participated in the vote -->
5-
* Deciders: @gregsdennis @jdesrosiers @jviotti @mwadams @karenetheridge @awwright @benjam @relequestual
5+
* Deciders: @gregsdennis @jdesrosiers @julian @jviotti @mwadams @karenetheridge @relequestual
66
* Date: 2024-11-02
77
* Technical Story: https://github.com/json-schema-org/json-schema-spec/issues/1520
88
* Voting issue: https://github.com/json-schema-org/TSC/issues/19
9+
For - @gregsdennis @jdesrosiers @jviotti @mwadams @karenetheridge
10+
Neutral - @relequestual
11+
Against - @julian
912

1013
## Context and Problem Statement
1114

@@ -25,8 +28,8 @@ However, the fact remains that our users consistently report (via questions in S
2528

2629
Due to this consistency in user expectations, we have decided to:
2730

28-
1. make format an assertion keyword and strictly,
29-
2. enforce it by moving the appropriate tests into the required section of the Test Suite.
31+
1. make format an assertion keyword, and
32+
2. strictly enforce it by moving the appropriate tests into the required section of the Test Suite and building them more completely.
3033

3134
## Decision Drivers
3235

@@ -65,7 +68,8 @@ The TSC has decided via vote (see voting issue above) that we should change `for
6568

6669
### Negative Consequences <!-- optional -->
6770

68-
* This is a breaking change, which means that we will likely have to re-educate our users.
71+
* This is a breaking change, which means that we will likely have to re-educate the users who correctly treat it as an annotation.
72+
* Older schemas which do not specify a version (`$schema`) may change their validation outcome.
6973
* The burden on implementations will be greater since format validation was previously optional.
7074

7175
## Links <!-- optional -->

0 commit comments

Comments
 (0)