Skip to content

Commit 8aeac94

Browse files
authored
Merge pull request #1549 from json-schema-org/gregsdennis/markdown-lint
Gregsdennis/markdown lint
2 parents e3a87d4 + 668be4b commit 8aeac94

16 files changed

+557
-339
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ Thanks for submitting a pull request! Please provide enough information so that
1515
### Issue & Discussion References
1616

1717
<!-- Pick at least one of the below options, and remove those which don't apply. -->
18-
- Closes #___ <!-- Replace ___ with the issue number this PR resolves -->
19-
- Related to #___ <!-- Use when the PR doesn't completely resolve an issue -->
20-
- Others? <!-- Add any additional notes or references here -->
18+
- Closes #___ <!-- Replace ___ with the issue number this PR resolves -->
19+
- Related to #___ <!-- Use when the PR doesn't completely resolve an issue -->
20+
- Others? <!-- Add any additional notes or references here -->
2121

2222
### Summary
2323

.github/SECURITY.md

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,24 @@
11
# Reporting Security Issues
22

3-
The JSON Schema project does not house any implementation of JSON Schema itself. If you have found a security issue in any implementation of JSON Schema, please contact the appropriate maintainers, per the projects security reporting guidelines, if any.
3+
The JSON Schema project does not house any implementation of JSON Schema itself.
4+
If you have found a security issue in any implementation of JSON Schema, please
5+
contact the appropriate maintainers, per the projects security reporting
6+
guidelines, if any.
47

5-
To report a security issue, please use the GitHub Security Advisory "https://github.com/json-schema-org/json-schema-spec/security/advisories/new" tab.
8+
To report a security issue, please use the GitHub Security Advisory
9+
"<https://github.com/json-schema-org/json-schema-spec/security/advisories/new>"
10+
tab.
611

7-
If you find a security issue in relation to the JSON Schema specification or another repository within this GitHub organization, please use the above.
12+
If you find a security issue in relation to the JSON Schema specification or
13+
another repository within this GitHub organization, please use the above.
814

9-
The JSON Schema project TSC will review and respond to all security reports. Please follow [coordinated disclosure](https://docs.github.com/en/code-security/security-advisories/guidance-on-reporting-and-writing/about-coordinated-disclosure-of-security-vulnerabilities).
15+
The JSON Schema project TSC will review and respond to all security reports.
16+
Please follow [coordinated disclosure](https://docs.github.com/en/code-security/security-advisories/guidance-on-reporting-and-writing/about-coordinated-disclosure-of-security-vulnerabilities).
17+
18+
If you are a maintainer of an implementation, please consider [adding a security
19+
policy](https://docs.github.com/en/code-security/getting-started/adding-a-security-policy-to-your-repository).
20+
If you need assistance in understanding a report, or remediation of a confirmed
21+
issue, please feel free to reach out to us on our Slack server, in the
22+
`#implementations` channel, and ask for a temporary private channel to discuss
23+
your situation or concerns.
1024

11-
If you are a maintainer of an implementation, please consider [adding a security policy](https://docs.github.com/en/code-security/getting-started/adding-a-security-policy-to-your-repository). If you need assistance in understanding a report, or remediation of a confirmed issue, please feel free to reach out to us on our Slack server, in the `#implementations` channel, and ask for a temporary private channel to discuss your situation or concerns.

.remarkrc-lint.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import remarkPresetLintMarkdownStyleGuide from "remark-preset-lint-markdown-styl
55
import remarkLintListItemIndent from "remark-lint-list-item-indent";
66
import remarkLintListItemSpacing from "remark-lint-list-item-spacing";
77
import remarkLintNoFileNameMixedCase from "remark-lint-no-file-name-mixed-case";
8+
import remarkLintNoFileNameIrregularCharacters from "remark-lint-no-file-name-irregular-characters";
89

910

1011
export default {
@@ -15,6 +16,7 @@ export default {
1516
remarkPresetLintMarkdownStyleGuide,
1617
[remarkLintListItemIndent, "one"],
1718
[remarkLintListItemSpacing, { checkBlanks: true }],
18-
[remarkLintNoFileNameMixedCase, false]
19+
[remarkLintNoFileNameMixedCase, false],
20+
[remarkLintNoFileNameIrregularCharacters, false]
1921
]
2022
};

.remarkrc.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import remarkGfm from "remark-gfm";
2+
import lintPreset from "./.remarkrc-lint.js";
3+
4+
5+
export default {
6+
plugins: [
7+
remarkGfm,
8+
lintPreset
9+
]
10+
};

CONTRIBUTING.md

Lines changed: 42 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,45 +2,71 @@
22

33
## Contributing to JSON Schema Specification
44

5-
Thanks for taking the time to contribute! 🎉👍
5+
Thanks for taking the time to contribute! 🎉👍
66

7-
JSON Schema is an evolving language. This repository contains the specification text as well as Pull Requests with suggested improvements and contributions.
7+
JSON Schema is an evolving language. This repository contains the specification
8+
text as well as Pull Requests with suggested improvements and contributions.
89

9-
Contributions that do not change the interpretation of the spec but instead improve legibility, fix editorial errors, clear up ambiguity and improve examples are encouraged and are often merged by a spec editor with little process.
10+
Contributions that do not change the interpretation of the spec but instead
11+
improve legibility, fix editorial errors, clear up ambiguity and improve
12+
examples are encouraged and are often merged by a spec editor with little
13+
process.
1014

11-
However, contributions that _do_ meaningfully change the interpretation of the spec must follow the Specification Development Process which is ⚠️currently under discussion and development⚠️.
15+
However, contributions that *do* meaningfully change the interpretation of the
16+
spec must follow the [Specification Development Process](./PROCESS.md).
1217

1318
## Issues
1419

15-
Issues should identify a problem, enhancement, or use case; and propose some course of action for the draft. For alternate support channels, see the [SUPPORT.md](https://github.com/json-schema-org/.github/blob/main/SUPPORT.md).
20+
Issues should identify a problem, enhancement, or use case; and propose some
21+
course of action for the draft. For alternate support channels, see the
22+
[SUPPORT.md](https://github.com/json-schema-org/.github/blob/main/SUPPORT.md).
1623

1724
## Pull Requests
1825

19-
We welcome pull requests, both for editorial suggestions and to resolve open issues.
26+
We welcome pull requests, both for editorial suggestions and to resolve open
27+
issues.
2028

21-
If the pull request would solve a particular issue, reference the issue in the pull request description.
29+
If the pull request would solve a particular issue, reference the issue in the
30+
pull request description.
2231

23-
Changes that would affect implementation behavior should typically be opened as an issue first.
32+
Changes that would affect implementation behavior should typically be opened as
33+
an issue first.
2434

25-
Generally, pull requests should be made to the `main` branch unless it is a patch update and we are in a patch phase. In that case there will be a branch named something like `2020-12-patch` that the PR should target instead.
35+
Generally, pull requests should be made to the `main` branch unless it is a
36+
patch update and we are in a patch phase. In that case there will be a branch
37+
named something like `2020-12-patch` that the PR should target instead.
2638

27-
Most PRs, including all PRs that impact implementation behavior, will be left open for a minimum of 14 days. Minor wording fixes may be merged more quickly once approved by a project member.
39+
Most PRs, including all PRs that impact implementation behavior, will be left
40+
open for a minimum of 14 days. Minor wording fixes may be merged more quickly
41+
once approved by a project member.
2842

2943
## Milestones
3044

31-
Each milestone is an estimation of the work that will be done for the next draft. Milestones are typically named after the meta-schema draft number, and the _open_ milestone with the lowest draft number is the current active project.
45+
Each milestone is an estimation of the work that will be done for the next
46+
draft. Milestones are typically named after the meta-schema draft number, and
47+
the *open* milestone with the lowest draft number is the current active project.
3248

33-
Issues may be removed from a milestoned due to lack of consensus, lack of anyone with the correct expertise to make a PR, or simply because we wish to publish a draft and defer the remaining issues to the next draft.
49+
Issues may be removed from a milestoned due to lack of consensus, lack of anyone
50+
with the correct expertise to make a PR, or simply because we wish to publish a
51+
draft and defer the remaining issues to the next draft.
3452

35-
Numbered milestones other than the lowest-numbered one are used to tentatively organize future work, but may be completely reorganized once work on that draft actually begins.
53+
Numbered milestones other than the lowest-numbered one are used to tentatively
54+
organize future work, but may be completely reorganized once work on that draft
55+
actually begins.
3656

37-
The `draft-future` milestone is for issues for which there is an agreement that they should be addressed, but no specific timeline.
57+
The `draft-future` milestone is for issues for which there is an agreement that
58+
they should be addressed, but no specific timeline.
3859

3960
## Code of Conduct
4061

41-
All official channels including the mailing list, GitHub organization and Slack server, follow our [Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md).
62+
All official channels including the mailing list, GitHub organization and Slack
63+
server, follow our
64+
[Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md).
4265

4366
## Have Questions?
4467

45-
You can join the `#specification` channel in our [Slack workspace](https://json-schema.org/slack) to interact with other community members involved in the Specification development, share new ideas and ask questions.
68+
You can join the `#specification` channel in our
69+
[Slack workspace](https://json-schema.org/slack) to interact with other
70+
community members involved in the Specification development, share new ideas and
71+
ask questions.
4672

0 commit comments

Comments
 (0)