From 68e58a2790f974ce67453721602d05f692ad5734 Mon Sep 17 00:00:00 2001 From: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com> Date: Fri, 26 Apr 2024 17:43:42 +0530 Subject: [PATCH 1/4] Update unevaluatedProperties.json https://github.com/json-schema-org/JSON-Schema-Test-Suite/issues/723 think removing the bar matches the test with the description, as foo itself is evaluated. --- tests/draft2020-12/unevaluatedProperties.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/draft2020-12/unevaluatedProperties.json b/tests/draft2020-12/unevaluatedProperties.json index ae29c9eb..89d26eec 100644 --- a/tests/draft2020-12/unevaluatedProperties.json +++ b/tests/draft2020-12/unevaluatedProperties.json @@ -528,8 +528,7 @@ { "description": "when if is true and has no unevaluated properties", "data": { - "foo": "then", - "bar": "bar" + "foo": "then" }, "valid": false }, From 41ec395cffdce48205d13bc3f3b2149bb21525fc Mon Sep 17 00:00:00 2001 From: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com> Date: Fri, 26 Apr 2024 17:47:44 +0530 Subject: [PATCH 2/4] Update unevaluatedProperties.json --- tests/draft2020-12/unevaluatedProperties.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/draft2020-12/unevaluatedProperties.json b/tests/draft2020-12/unevaluatedProperties.json index 89d26eec..be06efc0 100644 --- a/tests/draft2020-12/unevaluatedProperties.json +++ b/tests/draft2020-12/unevaluatedProperties.json @@ -530,7 +530,7 @@ "data": { "foo": "then" }, - "valid": false + "valid": true }, { "description": "when if is true and has unevaluated properties", From ab16b659f4d09d5cdf7df763e94088fee08a9a29 Mon Sep 17 00:00:00 2001 From: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com> Date: Sat, 27 Apr 2024 17:58:59 +0530 Subject: [PATCH 3/4] Update unevaluatedProperties.json --- tests/draft2020-12/unevaluatedProperties.json | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/draft2020-12/unevaluatedProperties.json b/tests/draft2020-12/unevaluatedProperties.json index be06efc0..1a9eaeff 100644 --- a/tests/draft2020-12/unevaluatedProperties.json +++ b/tests/draft2020-12/unevaluatedProperties.json @@ -526,12 +526,20 @@ }, "tests": [ { - "description": "when if is true and has no unevaluated properties", + "description": "when if is true and has unknown unevaluated properties", "data": { + "foo": "then", + "bar": "bar" + }, + "valid": false + }, + { + "decscription": "when if is true and has no unevaluated properties", + "data":{ "foo": "then" }, "valid": true - }, + } { "description": "when if is true and has unevaluated properties", "data": { From c5685e18a3b55bef1b69d7ae7aef6e21d5c57291 Mon Sep 17 00:00:00 2001 From: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com> Date: Sat, 27 Apr 2024 19:09:52 +0530 Subject: [PATCH 4/4] Fixing my mistakes --- tests/draft2020-12/unevaluatedProperties.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/draft2020-12/unevaluatedProperties.json b/tests/draft2020-12/unevaluatedProperties.json index 1a9eaeff..365d6d8b 100644 --- a/tests/draft2020-12/unevaluatedProperties.json +++ b/tests/draft2020-12/unevaluatedProperties.json @@ -534,12 +534,12 @@ "valid": false }, { - "decscription": "when if is true and has no unevaluated properties", + "description": "when if is true and has no unevaluated properties", "data":{ "foo": "then" }, "valid": true - } + }, { "description": "when if is true and has unevaluated properties", "data": {