Skip to content

Test that identifiers are not found inside unrecognized keywords #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2021
Merged

Test that identifiers are not found inside unrecognized keywords #484

merged 1 commit into from
May 8, 2021

Conversation

karenetheridge
Copy link
Member

@karenetheridge karenetheridge requested review from handrews and a team May 8, 2021 03:52
handrews
handrews approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It took me a bit to realize how the not worked but I think this covers it. As well as you can cover a "case" that could look like almost anything.

@karenetheridge karenetheridge merged commit 812f1f0 into master May 8, 2021
@karenetheridge karenetheridge deleted the ether/schemas-under-unknown-keywords branch May 8, 2021 16:18
suluke referenced this pull request in suluke/monobo May 9, 2021
@suluke
[json_schema] Implement several keyword validations
772e044 
- minimum
- maximum
- const
- contains
- minContains
- maxContains

Also fix bug in dynamic_schema's allocateJson
@karenetheridge karenetheridge mentioned this pull request Jun 28, 2021
Merged
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request Oct 21, 2021
@davishmcclurg
Only resolve ids in known keywords
db2d117 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request Apr 22, 2022
@davishmcclurg
Only resolve ids in known keywords
28281e6 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request May 15, 2023
@davishmcclurg
Only resolve ids in known keywords
64b7412 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request May 16, 2023
@davishmcclurg
Only resolve ids in known keywords
aac36a1 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request May 16, 2023
@davishmcclurg
Only resolve ids in known keywords
4ed8dfd 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request May 22, 2023
@davishmcclurg
Only resolve ids in known keywords
30ead71 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request May 26, 2023
@davishmcclurg
Only resolve ids in known keywords
7aca73d 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
davishmcclurg added a commit to davishmcclurg/json_schemer that referenced this pull request May 26, 2023
@davishmcclurg
Only resolve ids in known keywords
7fd971f 
It looks like we were too permissive in: #71

This addresses issues from:

- json-schema-org/JSON-Schema-Test-Suite#471
- json-schema-org/JSON-Schema-Test-Suite#484

The first issue is more important, I think. We were resolving `$id` in
keywords like `enum` and `const`, which is unexpected since those values
are literal.

The second issue is a little trickier. It's possible people are using
non-standard keys to store reference schemas, which will cause issues
since this only looks in `definitions` now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karenetheridge @handrews