consolidate bignum and overflow tests in one file under optional/

karenetheridge · karenetheridge · commit 42b8de39e8ca · 2021-12-30T11:33:33.000-08:00
an overflow result is an error, which may not be treated as valid: false by an implementation
diff --git a/tests/draft-next/multipleOf.json b/tests/draft-next/multipleOf.json
@@ -122,16 +122,5 @@
                 "valid": false
             }
         ]
-    },
-    {
-        "description": "invalid instance should not raise error when float division = inf",
-        "schema": {"type": "integer", "multipleOf": 0.123456789},
-        "tests": [
-            {
-                "description": "always invalid, but naive implementations may raise an overflow error",
-                "data": 1e308,
-                "valid": false
-            }
-        ]
     }
 ]
diff --git a/tests/draft-next/optional/bignum.json b/tests/draft-next/optional/bignum.json
@@ -159,5 +159,34 @@
                 "valid": false
             }
         ]
+    },
+    {
+        "description": "multipleOf with a very large dividend",
+        "schema": {
+            "multipleOf": 0.123456789
+        },
+        "tests": [
+            {
+                "description": "true result",
+                "data": 1.23456789e+307,
+                "valid": true
+            },
+            {
+                "description": "false result",
+                "data": 1e308,
+                "valid": false
+            }
+        ]
+    },
+    {
+        "description": "all integers are multiples of 0.5, if overflow is handled",
+        "schema": { "multipleOf": 0.5 },
+        "tests": [
+            {
+                "description": "valid if optional overflow handling is implemented",
+                "data": 1e308,
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft-next/optional/float-overflow.json b/tests/draft-next/optional/float-overflow.json
diff --git a/tests/draft2019-09/multipleOf.json b/tests/draft2019-09/multipleOf.json
@@ -122,16 +122,5 @@
                 "valid": false
             }
         ]
-    },
-    {
-        "description": "invalid instance should not raise error when float division = inf",
-        "schema": {"type": "integer", "multipleOf": 0.123456789},
-        "tests": [
-            {
-                "description": "always invalid, but naive implementations may raise an overflow error",
-                "data": 1e308,
-                "valid": false
-            }
-        ]
     }
 ]
diff --git a/tests/draft2019-09/optional/bignum.json b/tests/draft2019-09/optional/bignum.json
@@ -159,5 +159,34 @@
                 "valid": false
             }
         ]
+    },
+    {
+        "description": "multipleOf with a very large dividend",
+        "schema": {
+            "multipleOf": 0.123456789
+        },
+        "tests": [
+            {
+                "description": "true result",
+                "data": 1.23456789e+307,
+                "valid": true
+            },
+            {
+                "description": "false result",
+                "data": 1e308,
+                "valid": false
+            }
+        ]
+    },
+    {
+        "description": "all integers are multiples of 0.5, if overflow is handled",
+        "schema": { "multipleOf": 0.5 },
+        "tests": [
+            {
+                "description": "valid if optional overflow handling is implemented",
+                "data": 1e308,
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft2019-09/optional/float-overflow.json b/tests/draft2019-09/optional/float-overflow.json
diff --git a/tests/draft2020-12/multipleOf.json b/tests/draft2020-12/multipleOf.json
@@ -122,16 +122,5 @@
                 "valid": false
             }
         ]
-    },
-    {
-        "description": "invalid instance should not raise error when float division = inf",
-        "schema": {"type": "integer", "multipleOf": 0.123456789},
-        "tests": [
-            {
-                "description": "always invalid, but naive implementations may raise an overflow error",
-                "data": 1e308,
-                "valid": false
-            }
-        ]
     }
 ]
diff --git a/tests/draft2020-12/optional/bignum.json b/tests/draft2020-12/optional/bignum.json
@@ -159,5 +159,34 @@
                 "valid": false
             }
         ]
+    },
+    {
+        "description": "multipleOf with a very large dividend",
+        "schema": {
+            "multipleOf": 0.123456789
+        },
+        "tests": [
+            {
+                "description": "true result",
+                "data": 1.23456789e+307,
+                "valid": true
+            },
+            {
+                "description": "false result",
+                "data": 1e308,
+                "valid": false
+            }
+        ]
+    },
+    {
+        "description": "all integers are multiples of 0.5, if overflow is handled",
+        "schema": { "multipleOf": 0.5 },
+        "tests": [
+            {
+                "description": "valid if optional overflow handling is implemented",
+                "data": 1e308,
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft2020-12/optional/float-overflow.json b/tests/draft2020-12/optional/float-overflow.json
diff --git a/tests/draft4/multipleOf.json b/tests/draft4/multipleOf.json
@@ -122,16 +122,5 @@
                 "valid": false
             }
         ]
-    },
-    {
-        "description": "invalid instance should not raise error when float division = inf",
-        "schema": {"type": "integer", "multipleOf": 0.123456789},
-        "tests": [
-            {
-                "description": "always invalid, but naive implementations may raise an overflow error",
-                "data": 1e308,
-                "valid": false
-            }
-        ]
     }
 ]
diff --git a/tests/draft4/optional/bignum.json b/tests/draft4/optional/bignum.json
@@ -161,5 +161,34 @@
                 "valid": false
             }
         ]
+    },
+    {
+        "description": "multipleOf with a very large dividend",
+        "schema": {
+            "multipleOf": 0.123456789
+        },
+        "tests": [
+            {
+                "description": "true result",
+                "data": 1.23456789e+307,
+                "valid": true
+            },
+            {
+                "description": "false result",
+                "data": 1e308,
+                "valid": false
+            }
+        ]
+    },
+    {
+        "description": "all integers are multiples of 0.5, if overflow is handled",
+        "schema": { "multipleOf": 0.5 },
+        "tests": [
+            {
+                "description": "valid if optional overflow handling is implemented",
+                "data": 1e308,
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft4/optional/float-overflow.json b/tests/draft4/optional/float-overflow.json
diff --git a/tests/draft6/multipleOf.json b/tests/draft6/multipleOf.json
@@ -122,16 +122,5 @@
                 "valid": false
             }
         ]
-    },
-    {
-        "description": "invalid instance should not raise error when float division = inf",
-        "schema": {"type": "integer", "multipleOf": 0.123456789},
-        "tests": [
-            {
-                "description": "always invalid, but naive implementations may raise an overflow error",
-                "data": 1e308,
-                "valid": false
-            }
-        ]
     }
 ]
diff --git a/tests/draft6/optional/bignum.json b/tests/draft6/optional/bignum.json
@@ -159,5 +159,34 @@
                 "valid": false
             }
         ]
+    },
+    {
+        "description": "multipleOf with a very large dividend",
+        "schema": {
+            "multipleOf": 0.123456789
+        },
+        "tests": [
+            {
+                "description": "true result",
+                "data": 1.23456789e+307,
+                "valid": true
+            },
+            {
+                "description": "false result",
+                "data": 1e308,
+                "valid": false
+            }
+        ]
+    },
+    {
+        "description": "all integers are multiples of 0.5, if overflow is handled",
+        "schema": { "multipleOf": 0.5 },
+        "tests": [
+            {
+                "description": "valid if optional overflow handling is implemented",
+                "data": 1e308,
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft6/optional/float-overflow.json b/tests/draft6/optional/float-overflow.json
diff --git a/tests/draft7/multipleOf.json b/tests/draft7/multipleOf.json
@@ -122,16 +122,5 @@
                 "valid": false
             }
         ]
-    },
-    {
-        "description": "invalid instance should not raise error when float division = inf",
-        "schema": {"type": "integer", "multipleOf": 0.123456789},
-        "tests": [
-            {
-                "description": "always invalid, but naive implementations may raise an overflow error",
-                "data": 1e308,
-                "valid": false
-            }
-        ]
     }
 ]
diff --git a/tests/draft7/optional/bignum.json b/tests/draft7/optional/bignum.json
@@ -159,5 +159,34 @@
                 "valid": false
             }
         ]
+    },
+    {
+        "description": "multipleOf with a very large dividend",
+        "schema": {
+            "multipleOf": 0.123456789
+        },
+        "tests": [
+            {
+                "description": "true result",
+                "data": 1.23456789e+307,
+                "valid": true
+            },
+            {
+                "description": "false result",
+                "data": 1e308,
+                "valid": false
+            }
+        ]
+    },
+    {
+        "description": "all integers are multiples of 0.5, if overflow is handled",
+        "schema": { "multipleOf": 0.5 },
+        "tests": [
+            {
+                "description": "valid if optional overflow handling is implemented",
+                "data": 1e308,
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft7/optional/float-overflow.json b/tests/draft7/optional/float-overflow.json

Original file line number	Diff line number	Diff line change
`@@ -122,16 +122,5 @@`
`122`	`122`	`"valid": false`
`123`	`123`	`}`
`124`	`124`	`]`
`125`		`- },`
`126`		`- {`
`127`		`- "description": "invalid instance should not raise error when float division = inf",`
`128`		`- "schema": {"type": "integer", "multipleOf": 0.123456789},`
`129`		`- "tests": [`
`130`		`- {`
`131`		`- "description": "always invalid, but naive implementations may raise an overflow error",`
`132`		`- "data": 1e308,`
`133`		`- "valid": false`
`134`		`- }`
`135`		`- ]`
`136`	`125`	`}`
`137`	`126`	`]`