Skip to content

Commit e42a13f

Browse files
committed
Get working happily with angular 1.3
1 parent 73d3e45 commit e42a13f

File tree

5 files changed

+20
-21
lines changed

5 files changed

+20
-21
lines changed

bower.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@
3030
"coverage"
3131
],
3232
"dependencies": {
33-
"angular": "~1.2.18",
33+
"angular": "~1.3.0",
3434
"tv4": "~1.0.15",
3535
"pickadate": "~3.5.2",
36-
"angular-sanitize": "~1.2.18",
36+
"angular-sanitize": "~1.3.0",
3737
"bootstrap-vertical-tabs": "~1.1.0",
3838
"objectpath": "~1.0.2"
3939
},

dist/schema-form.min.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,8 @@ angular.module('schemaForm').provider('schemaFormDecorators',['$compileProvider'
141141
$http.get(url,{ cache: $templateCache }).then(function(res){
142142
var key = form.key ? ObjectPathProvider.stringify(form.key).replace(/"/g, '"') : '';
143143
var template = res.data.replace(/\$\$value\$\$/g,'model'+key);
144-
$compile(template)(scope,function(clone){
145-
element.replaceWith(clone);
146-
});
144+
element.html(template);
145+
$compile(element.contents())(scope);
147146
});
148147
once();
149148
}

examples/bootstrap-example.html

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!DOCTYPE html>
2-
<html ng-app="test">
2+
<html>
33
<head>
44
<meta charset="utf-8">
55
<title>Bootstrap Schema Form example</title>
@@ -28,14 +28,15 @@
2828
.schema { height: 800px; }
2929
</style>
3030
</head>
31-
<body ng-controller="TestCtrl">
31+
<body ng-app="test" ng-controller="TestCtrl">
3232

3333
<div class="col-md-12">
3434
<h1>Schema Form Example</h1>
3535
<div class="row">
3636
<div class="col-sm-4">
3737
<h3>The Generated Form</h3>
38-
<form name="ngform" sf-model="modelData" sf-form="form" sf-schema="schema" sf-decorator="{{decorator}}">
38+
<form name="ngform" sf-model="modelData" sf-form="form" sf-schema="schema">
39+
<div sf-decorator="{{decorator}}"></div>
3940
</form>
4041
<h3>Model</h3>
4142
<pre ng-cloak>{{pretty()}}</pre>
@@ -61,26 +62,27 @@ <h3>Schema</h3>
6162
<script type="text/javascript" src="http://cdn.jsdelivr.net/g/[email protected]"></script>
6263
<script type="text/javascript" src="../bower_components/tv4/tv4.js"></script>
6364
<script type="text/javascript" src="../bower_components/ace-builds/src-min-noconflict/ace.js"></script>
65+
6466
<script type="text/javascript" src="../bower_components/angular/angular.js"></script>
65-
<script type="text/javascript" src="../bower_components/angular-sanitize/angular-sanitize.min.js"></script>
67+
<script type="text/javascript" src="../bower_components/angular-sanitize/angular-sanitize.js"></script>
68+
6669
<script type="text/javascript" src="../bower_components/angular-ui-sortable/sortable.js"></script>
6770
<script type="text/javascript" src="../bower_components/angular-ui-ace/ui-ace.js"></script>
6871
<script type="text/javascript" src="../bower_components/objectpath/lib/ObjectPath.js"></script>
6972
<script type="text/javascript" src="../bower_components/pickadate/lib/picker.js"></script>
7073
<script type="text/javascript" src="../bower_components/pickadate/lib/picker.date.js"></script>
7174
<script type="text/javascript" src="../bower_components/pickadate/lib/translations/sv_SE.js"></script>
75+
7276
<script type="text/javascript" src="../dist/schema-form.min.js"></script>
7377
<script type="text/javascript" src="../dist/bootstrap-decorator.min.js"></script>
74-
<script type="text/javascript" src="../dist/bootstrap-datepicker.min.js"></script>
78+
<!-- <script type="text/javascript" src="../dist/bootstrap-datepicker.min.js"></script> -->
7579
<script type="text/javascript">
7680

77-
angular.module('test',['schemaForm','ui.ace','ObjectPath']);
78-
79-
function TestCtrl($scope,$http){
81+
angular.module('test',['schemaForm','ui.ace']).controller('TestCtrl', function($scope,$http){
8082

8183
$scope.tests = [
82-
{ name: "Complex Key Support", data: 'data/keys.json' },
8384
{ name: "Simple", data: 'data/simple.json' },
85+
{ name: "Complex Key Support", data: 'data/complex-keys.json' },
8486
{ name: "Array", data: 'data/array.json' },
8587
{ name: "Tab Array", data: 'data/tabarray.json' },
8688
{ name: "Kitchen Sink", data: 'data/sink.json' }
@@ -144,7 +146,7 @@ <h3>Schema</h3>
144146
alert(msg);
145147
};
146148

147-
}
149+
});
148150

149151
</script>
150152
</body>

examples/data/keys.json renamed to examples/data/complex-keys.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,13 @@
44
"title": "Complex Key Support",
55
"properties": {
66
"a[\"b\"].c": {
7-
"type": "text",
8-
"title": "Paths do not overflow their keys."
7+
"type": "text"
98
},
109
"simple": {
1110
"type": "object",
1211
"properties": {
1312
"prøp": {
14-
"title": "Property",
13+
"title": "UTF8 in both dot and bracket notation",
1514
"type": "string"
1615
}
1716
}

src/services/decorators.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ angular.module('schemaForm').provider('schemaFormDecorators',['$compileProvider'
5353
$http.get(url,{ cache: $templateCache }).then(function(res){
5454
var key = form.key ? ObjectPathProvider.stringify(form.key).replace(/"/g, '&quot;') : '';
5555
var template = res.data.replace(/\$\$value\$\$/g,'model'+key);
56-
$compile(template)(scope,function(clone){
57-
element.replaceWith(clone);
58-
});
56+
element.html(template);
57+
$compile(element.contents())(scope);
5958
});
6059
once();
6160
}

0 commit comments

Comments
 (0)