Linted

Author: Anthropic

src/directives/sf-array.directive.spec.js

@@ -12,6 +12,7 @@ var runSync = function(scope, tmpl) {
 
 describe('sf-array.directive.js', function() {
   var exampleSchema;
+  var tmpl;
   beforeEach(module('schemaForm'));
   beforeEach(
     module(function($sceProvider) {
@@ -76,7 +77,7 @@ describe('sf-array.directive.js', function() {
 
     inject(function($compile, $rootScope) {
       var scope = $rootScope.$new();
-      scope.model = { names: [{ name: "0"}, {name: "1"}, {name: "2"}, {name: "3"}]};
+      scope.model = { names: [{ name: "0" }, { name: "1" }, { name: "2" }, { name: "3" }]};
 
       scope.schema = exampleSchema;
 
@@ -97,7 +98,7 @@ describe('sf-array.directive.js', function() {
         scope.model.names[1].name.should.equal("2");
         scope.model.names[2].name.should.equal("3");
         done();
-      }, 0)
+      }, 0);
     });
   });
 });

src/directives/sf-field.directive.js

@@ -59,7 +59,7 @@ export default function($parse, $compile, $interpolate, sfErrorMessage, sfPath,
               if(typeof key[key.length-1] === 'number' && scope.form.key.length >= 1) {
                 let trim = scope.form.key.length - key.length;
                 scope.completeKey =
-                  trim > 0 ?  key.concat(scope.form.key.slice(-trim)) : key;
+                  trim > 0 ? key.concat(scope.form.key.slice(-trim)) : key;
               }
               else {
                 scope.completeKey = scope.form.key.slice();
@@ -308,31 +308,32 @@ export default function($parse, $compile, $interpolate, sfErrorMessage, sfPath,
 
             // If the entire schema form is destroyed we don't touch the model
             if (!scope.externalDestructionInProgress) {
-              var destroyStrategy = form.destroyStrategy ||
+              const destroyStrategy = form.destroyStrategy ||
                                     (scope.options && scope.options.destroyStrategy) || 'remove';
               // No key no model, and we might have strategy 'retain'
               if (key && destroyStrategy !== 'retain') {
-
                 // Type can also be a list in JSON Schema
-                var type = (form.schema && form.schema.type) || '';
+                const type = (form.schema && form.schema.type) || '';
 
                 // Empty means '',{} and [] for appropriate types and undefined for the rest
                 let value;
                 if (destroyStrategy === 'empty') {
                   value = type.indexOf('string') !== -1 ? '' :
                     type.indexOf('object') !== -1 ? {} :
                     type.indexOf('array') !== -1 ? [] : undefined;
-                } else if (destroyStrategy === 'null') {
+                }
+                else if (destroyStrategy === 'null') {
                   value = null;
                 }
 
                 if (value !== undefined) {
                   sfSelect(key, scope.model, value);
-                } else {
+                }
+                else {
                   // Get the object parent object
                   let obj = scope.model;
                   if (key.length > 1) {
-                    obj = sfSelect(key.slice(0, key.length - 1), obj)
+                    obj = sfSelect(key.slice(0, key.length - 1), obj);
                   }
 
                   // parent can be undefined if the form hasn't been filled out

src/directives/sf-field.directive.spec.js

@@ -1,82 +1,84 @@
+/* eslint-disable quotes, no-var */
+/* disabling quotes makes it easier to copy tests into the example app */
 chai.should();
 
 var runSync = function (scope, tmpl) {
   var directiveScope = tmpl.isolateScope();
-  var stub = sinon.stub(directiveScope, 'resolveReferences', function(schema, form) {
+  sinon.stub(directiveScope, 'resolveReferences', function(schema, form) {
     directiveScope.render(schema, form);
   });
   scope.$apply();
-}
+};
 
-describe('sf-field.directive.js',function() {
+describe('sf-field.directive.js', function() {
   beforeEach(module('schemaForm'));
   beforeEach(
-    module(function($sceProvider){
+    module(function($sceProvider) {
       $sceProvider.enabled(false);
     })
   );
 
   var keyTests = [
     {
-      name: 'array of objects',
-      targetKey: ['arrayOfObjects', 0, 'stringVal'],
+      "name": "array of objects",
+      "targetKey": [ "arrayOfObjects", 0, "stringVal" ],
 
-      schema: {
-        type: 'object',
-        properties: {
-          arrayOfObjects: {
-            type: 'array',
-            items: {
-              type: 'object',
-              properties: {
-                stringVal: {
-                  type: 'string',
-                  'x-schema-form': {
-                    htmlClass: 'targetKey'
-                  }
-                }
-              }
-            }
-          }
-        }
+      "schema": {
+        "type": "object",
+        "properties": {
+          "arrayOfObjects": {
+            "type": "array",
+            "items": {
+              "type": "object",
+              "properties": {
+                "stringVal": {
+                  "type": "string",
+                  "x-schema-form": {
+                    "htmlClass": "targetKey",
+                  },
+                },
+              },
+            },
+          },
+        },
       },
 
-      form: [
+      "form": [
         {
-          key: 'arrayOfObjects',
-          items: [
+          "key": "arrayOfObjects",
+          "items": [
             {
-              key: 'arrayOfObjects[].stringVal'
-            }
-          ]
-        }
-      ]
+              "key": "arrayOfObjects[].stringVal",
+            },
+          ],
+        },
+      ],
     },
 
     {
-      name: 'array of strings',
-      targetKey: ['arrayOfStrings', 0],
+      "name": "array of strings",
+      "targetKey": [ "arrayOfStrings", 0 ],
 
-      schema: {
-        type: 'object',
-        properties: {
-          arrayOfStrings: {
-            type: 'array',
-            items: {
-              type: 'string',
-              'x-schema-form': {
-                htmlClass: 'targetKey'
-              }
-            }
-          }
-        }
-      }
-    }
+      "schema": {
+        "type": "object",
+        "properties": {
+          "arrayOfStrings": {
+            "type": "array",
+            "items": {
+              "type": "string",
+              "x-schema-form": {
+                htmlClass: "targetKey",
+              },
+            },
+          },
+        },
+      },
+    },
   ];
 
   keyTests.forEach(function(keyTest) {
     it('should generate correct form keys for ' + keyTest.name, function(done) {
-      inject(function($compile,$rootScope) {
+      inject(function($compile, $rootScope) {
         var scope = $rootScope.$new();
         scope.model = {};
         scope.schema = keyTest.schema;
@@ -93,7 +95,7 @@ describe('sf-field.directive.js',function() {
 
     if (keyTest.form) {
       it('should generate correct form keys for ' + keyTest.name + ' with user specified form', function(done) {
-        inject(function($compile,$rootScope) {
+        inject(function($compile, $rootScope) {
           var scope = $rootScope.$new();
           scope.model = {};
           scope.schema = keyTest.schema;

src/services/schema-form.provider.spec.js

@@ -142,9 +142,6 @@ describe('schema-form.provider.js', function() {
               "attributes",
             ],
             "type": "fieldset",
-            "key": [
-              "attributes",
-            ],
             "items": [
               {
                 "title": "Eye color",
@@ -193,10 +190,6 @@ describe('schema-form.provider.js', function() {
                   "shoulders",
                 ],
                 "type": "fieldset",
-                "key": [
-                  "attributes",
-                  "shoulders",
-                ],
                 "items": [
                   {
                     "title": "left",
@@ -573,34 +566,33 @@ describe('schema-form.provider.js', function() {
                 properties: {
                   name: {
                     title: "Name",
-                    type: "string"
+                    type: "string",
                   },
                   age: {
                     title: "Age",
-                    type: "integer"
-                  }
+                    type: "integer",
+                  },
                 },
-                required: ["name"]
-              }
-            }
+                required: [ "name" ],
+              },
+            },
           },
-          required: ["dependentChildren"]
-        }
+          required: [ "dependentChildren" ],
+        },
       },
-      required: ["peopleLivingWithYou"]
+      required: [ "peopleLivingWithYou" ],
     };
 
     it('merge a schema that defines an array of objects with a form inside a section #900', function() {
       inject(function(schemaForm) {
-
         var formInsideSection = [{
           type: 'section',
           items: [{
             key: 'peopleLivingWithYou.dependentChildren',
             add: "Add Child",
             title: 'Dependent children details',
-            validationMessage: 'Complete all required fields for at least one child'
-          }]
+            validationMessage: 'Complete all required fields for at least one child',
+          }],
         }];
 
         var merged = schemaForm.merge(arrayObjectSchema, formInsideSection);
@@ -615,12 +607,11 @@ describe('schema-form.provider.js', function() {
 
     it('merge a schema that defines an array of objects with a form without a section #900', function() {
       inject(function(schemaForm) {
-
         var formWithoutSection = [{
           key: 'peopleLivingWithYou.dependentChildren',
           add: "Add Child",
           title: 'Dependent children details',
-          validationMessage: 'Complete all required fields for at least one child'
+          validationMessage: 'Complete all required fields for at least one child',
         }];
 
         var merged = schemaForm.merge(arrayObjectSchema, formWithoutSection);