Skip to content

Commit 91c879f

Browse files
committed
Fixes for #750 and #769 and #689
1 parent 6eab96c commit 91c879f

6 files changed

+12
-10
lines changed

CHANGELOG

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ v1.0.0-alpha.4 (unreleased)
22
--------------
33
This is the fourth (of many) alpha and is **NOT ready for production** yet.
44

5-
This alpha fixes a few bugs like array item deletion not working.
5+
This alpha fixes a bunch of array and destroyStrategy bugs.
66

77
## Known issues
88
- In Angular 1.5+ some odd behaviours can occur if refreshing a form with a flash of content experienced
@@ -11,7 +11,9 @@ This alpha fixes a few bugs like array item deletion not working.
1111
## Changes
1212

1313
### Fixed
14+
- #689 DestroyStrategy does not trigger when field no longer meets condition
1415
- #750 Removing an invalid array item doesn't work properly
16+
- #769 Model inside Array is not cleaned when Condition fails
1517

1618
v1.0.0-alpha.3
1719
--------------

dist/angular-schema-form-bootstrap.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*!
22
* angular-schema-form
33
* @version 1.0.0-alpha.4
4-
* @date Mon, 03 Apr 2017 12:57:37 GMT
4+
* @date Mon, 03 Apr 2017 14:20:22 GMT
55
* @link https://github.com/json-schema-form/angular-schema-form
66
* @license MIT
77
* Copyright (c) 2014-2017 JSON Schema Form
@@ -93,7 +93,7 @@ module.exports = __webpack_require__(3);
9393
/*!
9494
* angular-schema-form-bootstrap
9595
* @version 1.0.0-alpha.4
96-
* @date Sun, 02 Apr 2017 13:57:49 GMT
96+
* @date Mon, 03 Apr 2017 13:11:24 GMT
9797
* @link https://github.com/json-schema-form/angular-schema-form-bootstrap
9898
* @license MIT
9999
* Copyright (c) 2014-2017 JSON Schema Form

dist/angular-schema-form-bootstrap.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-schema-form.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*!
22
* angular-schema-form
33
* @version 1.0.0-alpha.4
4-
* @date Mon, 03 Apr 2017 13:29:07 GMT
4+
* @date Mon, 03 Apr 2017 14:20:22 GMT
55
* @link https://github.com/json-schema-form/angular-schema-form
66
* @license MIT
77
* Copyright (c) 2014-2017 JSON Schema Form
@@ -3613,7 +3613,7 @@ var _typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol
36133613
obj = sfSelect(key.slice(0, key.length - 1), obj);
36143614
}
36153615

3616-
if (obj && obj.$$hashKey && obj.$$hashKey !== scope.destroyed) {
3616+
if (obj && scope.destroyed && obj.$$hashKey && obj.$$hashKey !== scope.destroyed) {
36173617
return;
36183618
}
36193619

dist/angular-schema-form.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/directives/sf-field.directive.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ sfPath, sfSelect) {
307307
obj = sfSelect(key.slice(0, key.length - 1), obj);
308308
}
309309

310-
if(obj && obj.$$hashKey && obj.$$hashKey !== scope.destroyed) {
310+
if(obj && scope.destroyed && obj.$$hashKey && obj.$$hashKey !== scope.destroyed) {
311311
return;
312312
}
313313

0 commit comments

Comments
 (0)